[Pkg-sssd-devel] Bug#1069450: Follow up on bug #1069450
Simon Josefsson
simon at josefsson.org
Mon Mar 3 21:44:12 GMT 2025
Andrew Bartlett <abartlet at samba.org> writes:
> On Mon, 2025-03-03 at 14:38 +0000, Chen Shengqi wrote:
>> Hi Simon,
>>
>> > -----Original Message-----
>> > From: Simon Josefsson <simon at josefsson.org>
>> >
>> > Thanks for working on this! It is a bit delicate issue, and I've
>> > been
>> > unable to find the right spell to fix things. Could you propose
>> > this as
>> > a Salsa merge request, or at least a concrete patch? It would
>> > indeed be
>> > nice to get this fixed and uploaded.
>>
>> As I suggested, the patch should look like (not 100% sure it would
>> work):
>>
>> diff --git a/debian/tests/tests b/debian/tests/tests
>> index e164be5..2931d30 100755
>> --- a/debian/tests/tests
>> +++ b/debian/tests/tests
>> @@ -1,5 +1,10 @@
>> #!/bin/sh
>> set -e -u
>> +
>> +export DEB_BUILD_MAINT_OPTIONS=abi=-time64
>> +export CFLAGS=$(dpkg-buildflags --get CFLAGS)
>> +export CPPFLAGS=$(dpkg-buildflags --get CPPFLAGS)
>> +
>> cp -a . "$AUTOPKGTEST_TMP"
>> cd "$AUTOPKGTEST_TMP"
>> rm -rf obj debian
>>
>> P.S I would also suggest using make V=1 where possible to show the
>> actual build commands.
>
> The "will it work" is the key here. Like Simon, I agree it is
> delicate, and I'm not entirely convinced there is actually a valid
> spell.
One problem with the above is that this is the test will no longer
mimick reality: we cannot really ask that everyone adopts the same
non-time64 CFLAGS for everything they build.
At this point, I would be happy if we just got the package into trixie
and we may realize that it is somehow broken on armel/armhf. That is
better than not having it available on amd64 and arm64 at all.
/Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 1251 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-sssd-devel/attachments/20250303/000002db/attachment-0001.sig>
More information about the Pkg-sssd-devel
mailing list