[Pkg-sssd-devel] Bug#1124696: nss-wrapper: autopkgtest failure with glibc (>= 2.42-7): fatal error: crypt.h: No such file or directory

[Aurelien Jarno]

Source: nss-wrapper
Version: 1.1.16-3
Severity: serious
Tags: patch

Hi,

nss-wrapper autopkgtest fails when glibc (>= 2.42-7) is used:

| 51s [ 75%] Built target test_getpwuid_module
| 51s [ 79%] Building C object tests/CMakeFiles/test_initgroups.dir/test_initgroups.c.o
| 51s [ 83%] Linking C executable test_initgroups
| 51s [ 83%] Built target test_initgroups
| 51s [ 87%] Building C object tests/CMakeFiles/test_shadow.dir/test_shadow.c.o
| 51s /tmp/autopkgtest-lxc.50s8lr4o/downtmp/autopkgtest_tmp/tests/test_shadow.c:12:10: fatal error: crypt.h: No such file or directory
| 51s    12 | #include <crypt.h>
| 51s       |          ^~~~~~~~~
| 51s compilation terminated.
| 51s make[2]: *** [tests/CMakeFiles/test_shadow.dir/build.make:79: tests/CMakeFiles/test_shadow.dir/test_shadow.c.o] Error 1
| 51s make[1]: *** [CMakeFiles/Makefile2:1494: tests/CMakeFiles/test_shadow.dir/all] Error 2
| 51s make: *** [Makefile:166: all] Error 2

The full autopkgtest log is available there:
https://ci.debian.net/data/autopkgtest/testing/amd64/n/nss-wrapper/67552777/log.gz

This happens because, starting with version 2.42-7, libc6-dev dropped
its dependency on libcrypt-dev and instead expects packages to add an
explicit dependency themselves [1]. Fortunately, the fix is simply to
add this explicit dependency, as shown in the following patch:


--- nss-wrapper-1.1.16/debian/tests/control
+++ nss-wrapper-1.1.16/debian/tests/control
@@ -7,6 +7,7 @@
  libcmocka-dev,
  libnss-wrapper,
  netbase,
+ libcrypt-dev,
 Restrictions:
  allow-stderr,
 


I am sorry this went unnoticed until now, it wasn't caught during the
archive rebuild because the nss-wrapper tests are not run at build time.
If you are interested in enabling them, here is an additional patch to
do so:


--- nss-wrapper-1.1.16/debian/control
+++ nss-wrapper-1.1.16/debian/control
@@ -11,6 +11,7 @@
  cmake,
  libcmocka-dev,
  netbase,
+ libcrypt-dev <!nocheck>,
 Standards-Version: 4.7.2
 Vcs-Git: https://salsa.debian.org/sssd-team/nss-wrapper.git
 Vcs-Browser: https://salsa.debian.org/sssd-team/nss-wrapper
--- nss-wrapper-1.1.16/debian/rules
+++ nss-wrapper-1.1.16/debian/rules
@@ -5,6 +5,9 @@
 %:
 	dh $@ --builddirectory=build
 
+override_dh_auto_configure:
+	dh_auto_configure -- -DUNIT_TESTING=$(if $(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)),0,1)
+
 execute_after_dh_clean:
 	rm -fv compile_commands.json
 


Regards
Aurelien


[1] https://lists.debian.org/20250410053732.GA600740@subdivi.de