[Pkg-sugar-devel] Bug#970983: sugar-themes: does not define @text_view_bg named colour

[Simon McVittie]

Package: sugar-themes
Version: 0.117-1
Severity: important
Tags: upstream

GTK 3.24.22 introduced a new named colour, @text_view_bg, which the vte
terminal library has started to rely on, causing misrendering in themes
that do not define it (see
<https://gitlab.gnome.org/GNOME/vte/-/issues/284>). Other text-heavy
applications might also start to rely on that named colour in future,
particularly if they have a dark mode.

I've committed a workaround upstream in the 0.62.x branch, which will be
in Debian soon; but vte upstream asked me not to commit that change to
master, so the workaround will be going away in the next release cycle.
Please add @text_view_bg to this theme so it will not cause misrendering
in future.

The new colour is intended to be used as a background for text
views, contrasting well with @theme_text_color. For example, gnome-terminal
and other vte applications draw text in @theme_text_color on a background
of @text_view_bg.

The reference implementation is that in the light variant of GTK's default
Adwaita theme, @text_view_bg is the same white as @theme_base_color and
@content_view_bg, but in the dark variant of Adwaita, it's a darker grey
than @theme_base_color and @content_view_bg, to give white text better
contrast.

If this theme does not need to distinguish between text views and other
application content areas, defining @text_view_bg to be the same as
@theme_base_color or @content_view_bg would be appropriate.

Thanks,
    smcv