[Pkg-systemd-maintainers] spamassassin: systemd unit file

[Shawn]

On Sun, Jul 14, 2013 at 5:37 AM, Michael Stapelberg
<stapelberg at debian.org>wrote:

> Hi Shawn,
>
> why did you not contact pkg-systemd-maintainers before filing this
> bug? You are missing the usertag we use for tracking systemd-unit bugs
> and your service file does not follow best practices.
>
I tagged them after I filed them

>
> Please contact us before filing any more of these bugs.
>
> For the record, here is my proposed modification of the service file:
>
> --- i/debian/spamassassin.service
> +++ w/debian/spamassassin.service
> @@ -2,8 +2,6 @@
>  Description=Perl-based spam filter using text analysis
>
>  [Service]
> -EnvironmentFile=-/etc/default/spamassassin
> -ExecStartPre=/usr/bin/test 0 != ${ENABLED}
>  ExecStart=/usr/sbin/spamd
>  ExecReload=/bin/kill -HUP $MAINPID
>
I think the default of having the server disabled by default should be
preserved

>
> To disable services with systemd, users use “systemctl disable
> spamassassin.service” (or enable to enable).
>
> Updated patch attached.
>
> --
> Best regards,
> Michael
>



-- 

---
Shawn Landden
+1 360 389 3001 (SMS preferred)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20130714/96b714a0/attachment-0001.html>