[Pkg-systemd-maintainers] Review of http://paste.debian.net/16099/

Michael Stapelberg stapelberg at debian.org
Mon Jul 15 16:58:00 BST 2013


Hi Shawn,

Thanks for posting your service file for review before submitting.

I am referring to http://paste.debian.net/16099/, which contains
ExecStartPre=/bin/mkdir -p /var/run/iodine.

This is not idiomatic. All temporary directories which should be present
before starting the service should be configured via the tmpfiles.d(5)
mechanism. See
http://sources.debian.net/src/mpd/0.17.4-3/debian/mpd.tmpfiles?hl=1#L1
for an example.

Please fix this before submitting.

-- 
Best regards,
Michael




More information about the Pkg-systemd-maintainers mailing list