[Pkg-systemd-maintainers] Review of http://paste.debian.net/16099/

[Michael Biebl]

Hi,

Am 15.07.2013 18:14, schrieb Zbigniew Jędrzejewski-Szmek:
> On Mon, Jul 15, 2013 at 05:58:00PM +0200, Michael Stapelberg wrote:

>> Thanks for posting your service file for review before submitting.
>>
>> I am referring to http://paste.debian.net/16099/, which contains
>> ExecStartPre=/bin/mkdir -p /var/run/iodine.
>>
>> This is not idiomatic. All temporary directories which should be present
>> before starting the service should be configured via the tmpfiles.d(5)
>> mechanism.
> Hm, I know that this is the current recommended approach,
> but is that really better? It splits the configuration between two
> different places,

True

>  and also creates the directory unconditionally.

Also true.

> With enough services one'll have hundereds of empty directories

Is that really a concern and do you really expect hundreds of empty,
unused directories for typical installations?
Would seem rather odd to me to install hundreds of packages (mostly
daemon related) and then disable them.

> in /run/. I think that the mkdir-in-unit apporach is actually nicer.

The important thing here is, that tmpfiles does more, then just creating
the directory. It e.g. also applies SELinux security labels.
Doing that in a centralized ways seems to be vastly superiour then each
package doing on its own.

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20130715/39c58383/attachment-0001.sig>