[Pkg-systemd-maintainers] Bug#717540: Bug#717540: systemd: Please install zsh completion

[Felipe Sateler]

On Tue, Jul 23, 2013 at 11:12 PM, Michael Biebl <biebl at debian.org> wrote:
> Hi,
>
> Am 22.07.2013 16:16, schrieb Felipe Sateler:
>> The zsh completion file can be dropped into
>> /usr/share/zsh/vendor-completions into a file named _systemd (anything
>> starting with _).
>>
>> I'm not a zsh guru, but my testing suggests that files shipped in that
>> directory override the ones provided by zsh in
>> /u/s/zsh/functions/Completion (with the default zsh $fpath, at least).
>> This means no conflicts, and therefore zsh need not remove theirs.
>
> Could you get some conclusive answer how to do this properly?
> I'm not a zsh user so I'd like some confirmation on how to do this the
> right way.

That is the correct place, as confirmed by the zsh maintainers[1].
They also request if the zsh completion can be synced by upstream with
zsh, so that systemd doesn't have to ship it.

[1] http://lists.alioth.debian.org/pipermail/pkg-zsh-devel/2013-July/000789.html

> A working and tested patch would be even better, hint hint.

diff --git a/debian/rules b/debian/rules
index eb4942e..9cb5f7f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -142,6 +142,10 @@ override_dh_install:
                debian/systemd/lib/systemd/
        install --mode=755 debian/systemd-logind-launch \
                debian/systemd/lib/systemd/
+       # zsh completion
+       mkdir -p debian/systemd/usr/share/zsh/vendor-completions/
+       install --mode=644 shell-completion/systemd-zsh-completion.zsh \
+               debian/systemd/usr/share/zsh/vendor-completions/_systemd
        # remove duplicates
        # files shipped by systemd-sysv / sysvinit
        rm debian/systemd/usr/share/man/man1/init.1


Not sure if this is the best part to add it... Upstream does not have
an install target for this file.


-- 

Saludos,
Felipe Sateler