[Pkg-systemd-maintainers] Bug#743712: systemd: systemctl should ignore sysv services if native available

[stlman at poczta.fm]

Package: systemd
Version: 204-8~bpo70+1
Severity: normal
Tags: patch

Hi,

I've got a problem with avah-daemon.service. I cannot enable it with
"systemctl enable" because 

1. its sysv version created from /etc/init.d/avahi-daemon requires dbus 
2. dbus is provided by a native systemd service file and
3. when insserv tries to enable avahi-daemon it complains that dbus is
not enabled

--8<---------------cut here---------------start------------->8---
# systemctl enable avahi-daemon.service
Synchronizing state for avahi-daemon.service with sysvinit using update-rc.d...
Executing /usr/sbin/update-rc.d avahi-daemon defaults
update-rc.d: using dependency based boot sequencing
insserv: Service dbus has to be enabled to start service avahi
insserv: exiting now!
update-rc.d: error: insserv rejected the script header
--8<---------------cut here---------------end--------------->8---

I assume (I haven't debugged it with gdb) returns r < 0 at systemctl.c:4256
which prevents systemct from doing anything more with native units.

And even if there was no insserv error enable_sysv_units() should not
operate on sysv services if native one are available because the native
ones may be designed (like avahi-daemon does) to be socket activated
and should not be overriden by sysv derived units. Hence, IMHO the hunk
removes the conditional continuation if found_native variable is true
in Michael's patch in Bug #709780 is wrong. The attached patch makes
systemctl work as I would expect.

-- System Information:
Debian Release: 7.4
  APT prefers stable-updates
  APT policy: (990, 'stable-updates'), (900, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=pl_PL.UTF-8, LC_CTYPE=pl_PL.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages systemd depends on:
ii  acl                  2.2.51-8
ii  adduser              3.113+nmu3
ii  dpkg                 1.16.12
ii  initscripts          2.88dsf-41+deb7u1
ii  libacl1              2.2.51-8
ii  libaudit0            1:1.7.18-1.1
ii  libc6                2.13-38+deb7u1
ii  libcap2              1:2.22-1.2
ii  libcap2-bin          1:2.22-1.2
ii  libcryptsetup4       2:1.4.3-4
ii  libdbus-1-3          1.6.8-1+deb7u1
ii  libgcrypt11          1.5.0-5+deb7u1
ii  libkmod2             9-3
ii  liblzma5             5.1.1alpha+20120614-2
ii  libpam0g             1.1.3-7.1
ii  libselinux1          2.1.9-5
ii  libsystemd-daemon0   204-8~bpo70+1
ii  libsystemd-journal0  204-8~bpo70+1
ii  libsystemd-login0    204-8~bpo70+1
ii  libudev1             204-8~bpo70+1
ii  libwrap0             7.6.q-24
ii  sysv-rc              2.88dsf-41+deb7u1
ii  udev                 204-8~bpo70+1
ii  util-linux           2.20.1-5.3

Versions of packages systemd recommends:
ii  libpam-systemd  204-8~bpo70+1

Versions of packages systemd suggests:
pn  systemd-ui  <none>

-- no debconf information

-- 
Łukasz Stelmach
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bug.txt
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20140405/a55ae5a3/attachment-0002.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-systemctl-Prefer-native-units.patch
Type: text/x-diff
Size: 824 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20140405/a55ae5a3/attachment-0002.patch>