[Pkg-systemd-maintainers] systemd support for milter-greylist

Christian Dröge person at christian-droege.de
Sun Feb 16 23:09:42 GMT 2014


Am 16.02.2014 23:46, schrieb Michael Biebl:
> Am 16.02.2014 23:33, schrieb Christian Dröge:
>> Am 16.02.2014 23:03, schrieb Michael Biebl:
>>> Am 16.02.2014 22:58, schrieb Christian Dröge:
>>>> +[Unit]
>>>> +Description = Grey listing filter for sendmail
>>>> +After = syslog.target
>>>
>>> Declaring an ordering for syslog.target is no longer
>>> required/recommended nowadays since both syslog-ng and rsyslog use
>>> socket-activation. So just drop that line.
>>> IIRC we even have lintian check for that?
>>
>> There is a check, but I found a bug in this check. If it has the format
>> "After = " instead of "After=" the check will not find this problem.
> 
> Probably worth a bug against lintian.

I will report it later then.

>> Systemd accepts both, but the documentation only refers to "After=",
>> etc. Should I remove the whitespace?
> 
> Yeah, both is valid syntax, yet After=foo is definitely more common.
> So I'd stick with that.

OK. I changed it. I attached the new patch.

Thank you for looking at the patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: systemd_milter_greylist.patch
Type: text/x-patch
Size: 3079 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20140217/14b3dc2e/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20140217/14b3dc2e/attachment-0002.sig>


More information about the Pkg-systemd-maintainers mailing list