[Pkg-systemd-maintainers] Bug#734460: network-manager: Issues related to systemd when upgrading from << 0.9.8.8-2

[Laurent Bigonville]

Package: network-manager
Version: 0.9.8.8-2
Severity: serious

Hi,

I'm opening this bug so this is not getting lost.

When upgrading from the previous versions the following events might
occurs when the user is running systemd:

1) The package was not enabling the systemd unit in the previous
versions.
2) NM was then started using the LSB script called network-manager. This
means that the cgroup was called network-manager.service.
3) During the upgrade the systemd unit is properly enabled and the LSB
script is masked by a symlink, this means that at some point during the
upgrade, the canonical name changes from network-manager.service to
NetworkManager.service
4) At the end of the upgrade, systemd looks for a NetworkManager.service
cgroups which is not existing and then concludes that the service is not
running at all.
5) Systemd tries to start the service, NM complains that there is an
other instance of itself running => boom

To fix this, I would propose to stop NM in the preinst script if we are
upgrading from the previous versions and that the user is running
systemd.

I don't think this will happen often as the combination "LSB script and
unit name not matching" and restart-after-upgrade is a common case.

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash