Bug#665720: iptables-persistent: unusable with systemd

[Michael Biebl]

Hi Jonathan,

On Sat, May 10, 2014 at 02:16:25PM +0100, Jonathan Wiltshire wrote:
> Control: severity -1 serious
> 
> Hi,
> 
> On Wed, May 07, 2014 at 06:20:02PM +0100, Jakub Warmuz wrote:
> > Unfortunately, I'm *unable to boot* the system with
> > netfilter-persistent systemd service enabled!
> > 
> > Removing "quiet" from the kernel parameters, reveals that it hangs
> > with the following message displayed in a loop:
> 
> Well this is a little embarassing. I'll upload a fix shortly, so I'd
> appreciate testing.
> 
> I couldn't actually reproduce the failure to boot in a freshly installed
> system, so I suspect this is probably a combination of additional packages
> you have installed. Downgrading a little for this reason.

I see you added
DefaultDependencies=no
and
Requires=systemd-modules-load
After=systemd-modules-load
to your netfilter-persistent.service file [1]

Aside from the fact, that you need to use systemd-modules-load.service
(you must not omit the file extension),
can you elaborate why you *Require* systemd-modules-load.service and why
that ordering?

Michael

P.S:In general, I don't think it's a good idea to hard-code such
dependencies on systemd internal units. We don't have any guarantees
that those names stay stable. That excludes the units defined in
systemd.special.


[1] http://sources.debian.net/src/iptables-persistent/1.0.1/systemd/netfilter-persistent.service