Bug#768577: Patch applied upstream

[intrigeri]

Hi,

Quentin Lefebvre wrote (24 Nov 2014 21:19:56 GMT) :
> So here is the point of view of the developers.
> The upstream patch works provided that "hash=plain" is mentioned in /etc/cryptab.

> To summarize:
> - when a user creates a plain dm-crypt device providing a --hash parameter along with
> a key file
> - he *should* be aware of the fact that the hash parameter is ignored
> - and as a consequence, he should write "hash=plain" in /etc/crypttab
> - in short, it's a cryptsetup bug, and systemd won't be "compatible with cryptsetup's
> bug"...

Well, cryptsetup(8) makes it quite clear that hash processing is only
used on *passphrases*. See the "NOTES ON PASSPHRASE PROCESSING FOR
PLAIN MODE" section. So, IMO that's not a bug in cryptsetup, but
rather the intended and documented way it works. Maybe it's worth
pointing systemd upstream at that piece of documentation.

Cheers,
-- 
intrigeri