Bug#761272: dh-systemd: deb-systemd-invoke stop not protected by || true

[Laurent Bigonville]

Package: dh-systemd
Version: 1.21
Severity: important

Hi,

The current lvm2 package is trying to start/stop a .socket unit that
doesn't exist (see: #760682)

The starting of the non existant socket on installation is suceeding
while stopping is failing on removal.

Looking at the generated maintainer scripts I seeing the following:

/var/lib/dpkg/info/lvm2.postinst:	deb-systemd-invoke start lvm2-monitor.socket >/dev/null || true
/var/lib/dpkg/info/lvm2.prerm:	deb-systemd-invoke stop lvm2-monitor.socket >/dev/null

As you can see the start is protected by "||true" while the stop is not.

I guess the stop and start should be symetric here. Apparently with
dh_installinit, invoke-rc.d was not protected at all making the
maintscript fail. I guess this is a sensible action?

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dh-systemd depends on:
ii  debhelper  9.20140817
ii  perl       5.20.0-6

dh-systemd recommends no packages.

Versions of packages dh-systemd suggests:
ii  augeas-tools  1.2.0-0.2

-- no debconf information