Bug#760168: dh-systemd: support for -X option

[Michael Stapelberg]

On Tue, Sep 2, 2014 at 9:42 AM, Simon McVittie <smcv at debian.org> wrote:
> On 02/09/14 08:34, Michael Stapelberg wrote:
>> Did you try whether it actually works already?
>
> Yes I did, and no it doesn't.
>
>> In dh_compress and dh_fixperms I see -X is documented but I don’t see
>> special code to support it.
>
> Library code in Debian::Debhelper parses -X options and
> $DH_ALWAYS_EXCLUDE and puts them in $dh{EXCLUDE}, then converts them
> into find(1) syntax and puts that in $dh{EXCLUDE_FIND}, but it's up to
> individual dh_* utilities to make use of one or the other of those.
Thanks for clarifying.

Could you please come up with a patch for supporting this? I’m very
constrained on time these days, so it’s unlikely I’d address the issue
anytime soon.

>
> In dh_compress:
>
>         if (@files && defined($dh{EXCLUDE}) && $dh{EXCLUDE}) {
>                 my @new=();
>                 foreach (@files) {
>                         my $ok=1;
>                         foreach my $x (@{$dh{EXCLUDE}}) {
>                                 if (/\Q$x\E/) {
>                                         $ok='';
>                                         last;
>                                 }
>                         }
>                         push @new,$_ if $ok;
>                 }
>                 @files=@new;
>         }
>
> and in dh_fixperms:
>
>         my $find_options='';
>         if (defined($dh{EXCLUDE_FIND}) && $dh{EXCLUDE_FIND} ne '') {
>                 $find_options="! \\( $dh{EXCLUDE_FIND} \\)";
>         }
>
> Regards,
>     S
>



-- 
Best regards,
Michael