Bug#782426: unblock: systemd/215-15

[Michael Biebl]

Hi Julien,

Am 13.04.2015 um 22:18 schrieb Julien Cristau:
> On Mon, Apr 13, 2015 at 22:03:51 +0200, Michael Biebl wrote:
> 
>> ++static int manager_dispatch_ask_password_fd(sd_event_source *source,
>> ++                                            int fd, uint32_t revents, void *userdata) {
>> ++        Manager *m = userdata;
>> ++
>> ++        assert(m);
>> ++
>> ++        flush_fd(fd);
>> ++
>> ++        m->have_ask_password = have_ask_password();
>> ++        if (m->have_ask_password < 0)
>> ++                /* Log error but continue. Negative have_ask_password
>> ++                 * is treated as unknown status. */
>> ++                log_error("Failed to list /run/systemd/ask-password: %s", strerror(m->have_ask_password));
> 
> shouldn't that be strerror(-m->have_ask_password)?

I think you are right. Thanks for checking so carefully.

I notice, that this line was changed later on in commit c33b3297 to
> log_error_errno(m->have_ask_password, "Failed to list
/run/systemd/ask-password: %m");

That helper function does use inverted error numbers. So v219 is indeed
not affected by this.

In any case, CCed Zbigniew, the author of the patch, maybe he can comment.

Julien, do you want me to make a followup upload fixing that (pending
confirmation from Zbigniew)?

Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20150413/4020cd6e/attachment-0002.sig>