Bug796588#: adjtimex: Has init script in runlevel S but no matching service file

Michael Biebl biebl at debian.org
Mon Dec 14 15:26:03 GMT 2015


Am 14.12.2015 um 16:19 schrieb Roger Shimizu:
> On Mon, Dec 14, 2015 at 11:57 PM, Felipe Sateler <fsateler at debian.org> wrote:
>> Another option is to simply not enable/start the service, and just
>> ship instructions on how to do that in README.Debian.
>>
>> Running it on postinst looks weird to me. We normally do not run
>> possibly long processes synchronously on package installs.
> 
> I agree to removing adjtimexconfig from postinst, which takes 70
> seconds during install, is a good idea.
> But the defconf selection on enable/disable service is another issue.
> Yes, without adjtimexconfig running on install implies the service is
> disabled by default. But user need an easy way to enable adjtimex
> service after adjtimexconfig running.
> Do you think it's okay to run debconf to let user decide whether to
> start the service after manually running adjtimexconf?

You could check for the existence of a config file in your sysv init
script and simply exit if it doesn't exist.
Under systemd the equivalent is a ConditionPathExists=/etc/foobar.conf

Does adjtimexconfig already write a config file? If not, maybe you can
consider making it write a flag file somewhere.

The drop all the debconf machinery and simply add a README.Debian
telling users that want to have adjtimex run during boot, need to
configure the tool once via adjtimexconfig.



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20151214/9b3b5781/attachment-0002.sig>


More information about the Pkg-systemd-maintainers mailing list