Bug#759001: [systemd-devel] sysv-generator: doesn't handle /etc/insserv/overrides or /etc/chkconfig.d

[Christian Seiler]

Am 18.02.2015 um 00:38 schrieb Ansgar Burchardt:
>> I've implemented both of these and attached a modified version of
>> the patch. Do you have any objections? If not, I'll ask for pre-
>> approval by the release team.
>
> The load_sysv function also has a heuristic to guess whether the init
> script support the "release" action or not:
>
>                          /* Try to figure out whether this init script supports
>                           * the reload operation. This heuristic looks for
>                           * "Usage" lines which include the reload option. */
>
> As far as I can see this will no longer work with the proposed changes
> when an override file is present: load_sysv will only process the
> override file and never see the "usage" line used in the heuristic.

Oh, nice catch, thanks!

I've changed the logic slightly and tested it in all four possible
combinations (w/ or w/o reload support, w/ or w/o override), it now
works as expected. I also looked at the function to see if there
were some other surprises in there, but the the rest just parses
headers.

I've attached an updated patch. Any objections to that?

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sysv-generator-add-support-for-etc-insserv-overrides.patch
Type: text/x-patch
Size: 7965 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20150218/1efa587f/attachment-0002.bin>