nbd-client and systemd

[Wouter Verhelst]

On Wed, Jul 15, 2015 at 10:00:07AM -0300, Felipe Sateler wrote:
> On 15 July 2015 at 04:34, Wouter Verhelst <wouter at debian.org> wrote:
> > nbd-client ships with an init script that does two things:
> > - If we're doing root-on-NBD, write the correct sysvinit sendsigs.omit.d file
> >   so that the nbd-client process serving the root filesystem doesn't get killed
> >   from under us at shutdown
> > - Connect nbd devices based on configuration in /etc/nbd-client.
> >
> > The former just needs to happen at some time before shutdown, so it
> > doesn't really matter when this happens. Also, for systemd this isn't
> > required, instead we need to change our argv[0] to get the same
> > functionality, which has already happened for nbd-client in 1:3.8-2.
> 
> I think systemd units should in general do one thing each. So if there
> is still 1. to be done (its not clear to me what you mean by happened
> already), it should be done in a unit separate from the nbd-client
> units.

Systemd deals with "don't kill this process at shutdown" in an entirely
different way from sysvinit, and the functionality which is required has
been added in 1:3.8-2. So that part isn't necessary anymore.

-- 
It is easy to love a country that is famous for chocolate and beer

  -- Barack Obama, speaking in Brussels, Belgium, 2014-03-26