Bug#786976: setserial: Please add systemd unit for rcS init.d script

[Martin Pitt]

Hello again,

Martin Pitt [2015-05-27 12:26 +0200]:
> As far as I can see, the most appropriate course here is to provide a
> systemd unit for setserial with more fine-grained ordering to relax
> the overly harsh "Default-Start: S" (as this really just needs to run
> before any getty)

Michael pointed out that we don't even need to start this in early
boot -- this only really needs to run before we start getty, right?

With that, the unit becomes a lot simpler.

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
diff -Nru setserial-2.17/debian/changelog setserial-2.17/debian/changelog
--- setserial-2.17/debian/changelog	2012-07-02 10:22:13.000000000 +0200
+++ setserial-2.17/debian/changelog	2015-05-27 16:31:01.000000000 +0200
@@ -1,3 +1,15 @@
+setserial (2.17-49) UNRELEASED; urgency=medium
+
+  * Add debian/setserial.service systemd unit, mostly to relax the very
+    demanding Before=sysinit.target plus After=remote-fs.target combination
+    resulting from the init.d script's $remote_fs dependency. This can easily
+    cause dependency loops when using NFS and NetworkManager.
+    (Closes: #786976, LP: #1452644)
+  * Add dh-systemd build dependency and call dh_systemd_enable in
+    debian/rules.
+
+ -- Martin Pitt <martin.pitt at ubuntu.com>  Wed, 27 May 2015 11:57:47 +0200
+
 setserial (2.17-48) unstable; urgency=low
 
   * new maintainer (Closes: #636122)
diff -Nru setserial-2.17/debian/control setserial-2.17/debian/control
--- setserial-2.17/debian/control	2012-06-22 10:14:10.000000000 +0200
+++ setserial-2.17/debian/control	2015-05-27 16:28:02.000000000 +0200
@@ -2,7 +2,7 @@
 Section: comm
 Priority: extra
 Maintainer: Thorsten Alteholz <debian at alteholz.de>
-Build-Depends: debhelper (>= 9), autotools-dev, po-debconf
+Build-Depends: debhelper (>= 9), dh-systemd, autotools-dev, po-debconf
 Standards-Version: 3.9.3.1
 Homepage: http://ftp.mcc.ac.uk/pub/linux/
 
diff -Nru setserial-2.17/debian/rules setserial-2.17/debian/rules
--- setserial-2.17/debian/rules	2012-06-22 10:14:10.000000000 +0200
+++ setserial-2.17/debian/rules	2015-05-27 11:57:46.000000000 +0200
@@ -75,6 +75,7 @@
 	dh_installdocs README pcmcia.repair
 	dh_installchangelogs
 	dh_installdebconf
+	dh_systemd_enable
 	dh_strip
 	dh_compress
 	dh_fixperms
diff -Nru setserial-2.17/debian/setserial.service setserial-2.17/debian/setserial.service
--- setserial-2.17/debian/setserial.service	1970-01-01 01:00:00.000000000 +0100
+++ setserial-2.17/debian/setserial.service	2015-05-27 16:24:20.000000000 +0200
@@ -0,0 +1,13 @@
+[Unit]
+Documentation=man:setserial(8)
+Description=controls configuration of serial ports
+Before=system-getty.slice
+
+[Service]
+Type=oneshot
+RemainAfterExit=yes
+ExecStart=/etc/init.d/setserial start
+ExecStop=/etc/init.d/setserial stop
+
+[Install]
+WantedBy=multi-user.target
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-systemd-maintainers/attachments/20150527/75fc6f51/attachment.sig>