Bug#798802: xorp: systemd integration using sd_notify

[Dhionel Díaz]

Package: xorp
Version: 1.8.5-4.1
Severity: normal
Tags: patch
Usertags: systemd-units
X-Debbugs-CC: pkg-systemd-maintainers at lists.alioth.debian.org

Dear Maintainer,

The attached patch incorporates systemd integration and notifications
via sd_notify to xorp_rtrmgr. It has been tested in a production router,
the tests were limited to the start, stop, restart and logging behaviour.

The patch also routes the log to the journal via stderr, therefore
eliminating the weekly restart performed by logrotate. That restart was
failing in a somewhat loaded router until the proposed changes where
applied. It was also found that the default output log setup was failing
to work with systemd and it was changed to a simple one which, as far as
I know, should be very portable.

The unit file was sent to the systemd maintainers for review and their
helpful directions have been followed.

I hope this patch can be useful.

Regards,


-- System Information:
Debian Release: 8.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=es_VE.UTF-8, LC_CTYPE=es_VE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xorp depends on:
ii  adduser              3.113+nmu3
ii  init-system-helpers  1.22
ii  libc6                2.19-18+deb8u1
ii  libgcc1              1:4.9.2-10
ii  libncurses5          5.9+20140913-1+b1
ii  libpcap0.8           1.6.2-2
ii  libssl1.0.0          1.0.1k-3+deb8u1
ii  libstdc++6           4.9.2-10
ii  libsystemd0          215-17+deb8u2
ii  libtinfo5            5.9+20140913-1+b1

Versions of packages xorp recommends:
ii  iputils-ping       3:20121221-5+b2
ii  iputils-tracepath  3:20121221-5+b2
ii  traceroute         1:2.0.20-2+b1

xorp suggests no packages.

-- Configuration Files:
/etc/default/xorp changed [not included]
/etc/xorp/config.boot changed [not included]

-- no debconf information



-- 
Dhionel Díaz
Centro Nacional de Desarrollo e Investigación en Tecnologías Libres
Ministerio del Poder Popular para
Educación Universitaria, Ciencia y Tecnología
-------------- next part --------------
A non-text attachment was scrubbed...
Name: systemd_def_log.patch
Type: text/x-diff
Size: 6741 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-systemd-maintainers/attachments/20150912/2fdb6b47/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-systemd-maintainers/attachments/20150912/2fdb6b47/attachment-0001.sig>