xorp service file

[Felipe Sateler]

Hi Dhionel,

On 9 September 2015 at 17:38, Dhionel Díaz <ddiaz at cenditel.gob.ve> wrote:
> Hi everyone,
>
> Following the directions in https://wiki.debian.org/systemd/HowToHelp
> I've attached a service file I've written for the xorp daemon, it has
> been tested in one of our production routers.

Great!

>
> I'll be awaiting your review.
>
> [Unit]
> Description=eXtensible Open Router Platform
> After=network.target remote-fs.target

I don't think remote-fs.target is required here, as having
DefaultDependencies=yes (the default) ensures all the basic
filesystems are mounted.

>
> [Service]
> EnvironmentFile=-/etc/default/xorp
> ExecStart=/usr/sbin/xorp_rtrmgr $DAEMON_OPTS

It would be better to pass the option to daemonize and make the
service Type=forking, otherwise systemd does not know when the service
is successfully started.

Maybe even pass -P and specify PIDFile= so that systemd knows for sure
what the main process is.

> TimeoutStopSec=233

Why this weird value?

> Restart=always

I don't know if xorp can be told to exit, but this would cause it to
be restarted in such a case.

>
> [Install]
> WantedBy=multi-user.target

Looks good otherwise to me!


-- 

Saludos,
Felipe Sateler