xorp service file

[Dhionel Díaz]

Hi Michael,

El 10/09/15 a las 11:41, Michael Biebl escribió:
> Hi!
> 
> Am 10.09.2015 um 15:43 schrieb Dhionel Díaz:
>> El 09/09/15 a las 21:26, Felipe Sateler escribió:
>>> On 9 September 2015 at 20:46, Dhionel Díaz <ddiaz at cenditel.gob.ve> wrote:
> 
>>>> As an alternative, ¿do you think it would be appropriate to include a
>>>> sd_notify call in xorp_rtrmgr main process and then use Type=notify?
>>>
>>> That would be even better. The problem with Type=simple (the default
>>> if no type is specified) is that systemd automatically assumes the
>>> service started up correctly. Which can be confusing if eg, the config
>>> is wrong: systemd would start the service, then the service would
>>> immediately fail. Much better is for systemd to know the service never
>>> started up correctly and let you know that.
>>
>>
>> OK, I'll prepare a patch. At first sight, it seems it would be a small one.
> 
> Just in case you want to read a bit more about why Type=simple can lead
> to unwanted/unexpected behaviour, see [1], especially Russ' reply [2].
> 
> Adding support for sd_notify is usually very simple. See [3] as an
> example. The most effort in this patch was actually to get the build
> system updated, since the openssh configure.ac is a bit odd.
> 
> Cheers,
> Michael
> 
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778913
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778913#30
> [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778913#67
> 

Thanks for the references, it's an interesting case.

Currently I'm about to test the patch, it was indeed a very simple
change once what I think it's the appropriate place to insert it was
identified. In this case most of the time was also used with the build
system, actually reading the documentation because I haven't worked with
Scons before now.

Regards,

-- 
Dhionel Díaz
Centro Nacional de Desarrollo e Investigación en Tecnologías Libres
Ministerio del Poder Popular para
Educación Universitaria, Ciencia y Tecnología

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20150910/75df6c81/attachment-0002.sig>