Bug#780522: init-system-helpers: deb-systemd-helper doesn't handle drop-ins and is inconsistent w/ systemd w.r.t. lists

[Christian Seiler]

Version: 1.34
Control: tags -1 - moreinfo

On 12/21/2016 01:53 PM, Felipe Sateler wrote:
> Control: tags -1 moreinfo
> On Sun, 15 Mar 2015 15:23:38 +0100 Christian Seiler <christian at iwakd.de> wrote:
>> Package: init-system-helpers
>> Version: 1.22
>> Severity: important
>> Tags: patch
>>
>> deb-systemd-helper doesn't handle drop-ins at all (only the main
>> service file is parsed) and it doesn't treat lists properly: when
>> creating links for Alias=, it doesn't properly treat multiple entries
>> in the same line ($1 instead of $_ used), when removing links for
>> Also=, it assumes that there's only ever one entry per line, and it
>> doesn't support systemd's syntax to reset a list to empty (which native
>> systemd supports for the [Install] section entries).
> 
> So, lets recap. Upstream considers ignoring dropins in the [Install]
> section a feature. I think we should follow upstream here (if they
> change we should also change of course). Given that, there is only
> minor benefit to handling empty lists (it's unlikely a single file
> will reset a list defined the previous line). However, handling
> multiple words per line is important. However, since the fix in
> #820359 landed, I think we should be OK here.
> 
> So, should this be marked as done, or am I missing something more your
> patch does?

Yes, you're right. I was hoping to be able to work on a patch for
upstream to support drop-ins in this case, but I didn't get to
that.

Since I agree that this should follow upstream, I'm closing this
bug report for now. Should I be able to create a patch for upstream
that does this and get upstream to accept this, I'll reopen this
bug report.

Regards,
Christian