Bug#802018: systemd: _SYSTEMCTL_SKIP_REDIRECT=true is leaked to daemon

[Martin Pitt]

Hello all,

Michael Biebl [2016-12-22  9:21 +0100]: > Am 16.10.2015 um 23:07 schrieb Sebastian Schmidt:
> Looking at that old code again, I actually don't remember, why we export
>  _SYSTEMCTL_SKIP_REDIRECT="true" at all and if the obvious fix would be
> to simply drop that else clause.

AFAIK the original intent was that if you call "/etc/init.d/foo start" this
would redirect to "systemctl start" which would run "Exec=/etc/init.d/foo
start" in the generated unit which must not do that same redirection again.

This should be sufficiently covered by the [ $PPID -ne 1 ] test, though. git
archeology shows that commit c04d0f71 introduced the script and both the
SKIP_REDIRECT and the [ $PPID -ne 1 ] were already present, though.

So, I can't think of a good reason to set this either, thanks for dropping it
from master.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20161225/34e13b14/attachment-0002.sig>