init-system-helpers openrc branch pull request

Benda Xu heroxbd at gentoo.org
Fri Feb 19 07:57:43 GMT 2016


Dear Martin and Michael,
Cc Andreas,

I have added openrc support to invoke-rc.d and update-rc.d in
collab-maint/init-system-helpers.git[1].  Does it look good to be
uploaded?

replying to Andreas below:

Andreas Henriksson <andreas at fatal.se> writes:

> On Fri, Feb 19, 2016 at 03:36:38PM +0900, Benda Xu wrote:
>> I have pushed an openrc branch into
>> collab-maint/init-system-helpers.git[1], to have openrc supports in
>> invoke-rc.d and update-rc.d.  I didn't add a changelog item though.
>
> Great that you implemented what I consider the preferred solution
> by implementing it in the same version as supports other init systems.

Yeah, as I said in the last email I agree it is the right way to move
forward to benefit everyone.

>> 
>> Could you please help review it?
>
> I've quickly looked at it and while not knowing anything in particular
> about openrc from the viewpoint of other init systems I don't see
> how your changes could possibly cause any problems for those.

Thanks for your positive comments.

>> 
>> After init-system-helpers make a version bump supporting openrc, I will
>> bump openrc to finish the transition.
>
> Please beware that I'm *not* the maintainer of init-system-helpers
> so please contact them for final review, merge and upload.

Probably it's a good chance to join to maintain invoke-rc.d and
update-rc.d for the long term.

Yours,
Benda

1. http://anonscm.debian.org/cgit/collab-maint/init-system-helpers.git/log/?h=openrc



More information about the Pkg-systemd-maintainers mailing list