Bug#746580: sysv-rc: [patch] much improved update-rc.d integration w/ systemd

[Felipe Sateler]

Control: tags -1 - patch

Hi Christian

On Sun, 15 Mar 2015 16:16:44 +0100 Christian Seiler <christian at iwakd.de>
wrote:
> Dear Maintainer,
>
> I have created a patch that implements the previously missing parts of
> systemd integration into update-rc.d, following along the lines of the
> patch I have written for deb-systemd-helper (bug #780522).

Sorry for the late review. I have removed the patch tag because it doesn't
apply anymore, and requires changes anyway.

>
> The patch now makes update-rc.d support:
>
>   - drop-in configuration snippets

This is deliberately not done by upstream systemd, and I think we should
follow suit. The reasoning is that snippets mostly represent admin
configuration, so it makes little sense to have admin configuration that is
redundant (the admin could have just added the link).

Moreover, if we intend to make update-rc.d call out to systemctl when
available, we should not add features not present there.

>   - multiple words per setting (i.e. "WantedBy=a b")

This looks good, but I think it is best to not use shellwords, as it
processes the systemd escapes. I think it is better to just use split.

>   - RequiredBy=, Alias=, Also=

+1

>
> (Note that the patch currently implements the full systemd logic of
> also looking at /run/systemd/generator*, which may or may not be
> something one wants or not - I would defer to the systemd team as to
> whether they'd want to see that included - but it should be consistent
> across update-rc.d and deb-systemd-helper.)

I don't think update-rc.d should ever look at /run/systemd. update-rc.d
should not behave like systemctl --runtime. We should just ignore stuff in
/run/systemd.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-systemd-maintainers/attachments/20160502/fec253ed/attachment-0001.html>