[debhelper-devel] Bug#841746: dh_systemd_enable: install timer files

[Felipe Sateler]

On 23 Oct 2016 4:41 a.m., "Niels Thykier" <niels at thykier.net> wrote:
>
> Felipe Sateler:
> > Package: debhelper
> > Version: 10.2.2
> > Severity: wishlist
> > Tags: patch upstream
> >
> > Hi,
> >
> > Please find attached a patch for installing timer units in
> > debian/package.timer, and a small refactor to DRY.
> >
> >
> > [...]
>
>
> Hi,
>
> Thanks for the patches; I am happy to apply them pending a review from
> the systemd maintainers.

Sure.

>
> AFAICT, a side-effect of the refactoring is that dh_systemd_enable will
> now *also* install debian/<pkg>@.target (etc.) if present.  Does that
> make sense in general case ?

Well, the only one that is forbidden is for .mount units, as the unit name
must match the mount path (but then, installing  <pkg>.mount doesn't make
sense either).

For the rest there is nothing forbidding it, although tmpfiles do not make
much sense.

If you prefer I can unroll the loop and remove the ones that don't make
sense.

>
> At the same time, I also noticed that the "FILES" section in
> dh_systemd_enable seems a bit out of date. :)

Yes. I didn't know how to present a list so I refrained from fixing this.
Or should we just have a section for each filetype?

Saludos
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20161023/d6ffe3ab/attachment-0002.html>