Bug#870704: warn if native systemd service files only wrap existing SysV/LSB init scripts

[Michael Biebl]

Package: lintian
Version: 2.5.52
Severity: normal

Looking at
https://codesearch.debian.net/search?q=Exec.*%3D%2Fetc%2Finit.d%2F
there are quite a few native systemd .service file which simply use the
existing SysV init script via
ExecStart/ExecStop/...

We should actively discourage that. For that I suggest to add a lintian
check. Finding affected packages should be as simple as running grep
"Exec.*=/etc/init.d/" on the .service files.

The main logic of more complex init scripts should be moved into helper
scripts which can be used directly from the service file and the init
script. This will also make the init scripts more readable and easier to
support other alternatives like runit or openrc.


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                          2.29-3
ii  bzip2                             1.0.6-8.1
ii  diffstat                          1.61-1+b1
ii  dpkg                              1.18.24
ii  file                              1:5.30-1
ii  gettext                           0.19.8.1-2+b1
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.32+b2
ii  libarchive-zip-perl               1.59-1
ii  libclass-accessor-perl            0.34-1
ii  libclone-perl                     0.38-2+b2
ii  libdigest-sha-perl                5.96-1+b3
ii  libdpkg-perl                      1.18.24
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libipc-run-perl                   0.96-1
ii  liblist-moreutils-perl            0.416-1+b3
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.0-5
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  liburi-perl                       1.71-1
ii  libxml-simple-perl                2.24-1
ii  libyaml-libyaml-perl              0.63-2+b2
ii  man-db                            2.7.6.1-2
ii  patchutils                        0.3.4-2
ii  perl                              5.26.0-5
ii  t1utils                           1.40-2
ii  xz-utils                          5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.18.24
ii  libhtml-parser-perl    3.72-3+b2
ii  libtext-template-perl  1.46-1

-- no debconf information