Bug#850703: systemd: incorrect LSB support with monit's init script

[Michael Biebl]

Am 09.01.2017 um 16:41 schrieb Martin Pitt:
> Hello Vincent,
> 
> Vincent Lefevre [2017-01-09 15:15 +0100]:
>> The monit service (from the monit package) should be started last and
>> stopped first. This is not the case with systemd.
>>
>> # Should-Start:      $all
>> # Should-Stop:       $all
> 
> Please note that the SysV concept of "$all" is notoriously broken (what if
> another package uses $all too?), and cannot be represented sensibly in any
> non-serial init system (systemd, upstart, and even sysv with startpar). If
> monit needs to start/stop after/before other services, these should be
> enumerated explicitly.

Heh, I was about to write the (almost) exact same reply :-)

> That said, the SysV generator could approximate this a bit better by running
> "After=multi-user.target" instead of "Before=multi-user.target", i. e. similar
> to Type=idle.

As I was curious, how many packages are potentially affected, I grepped
over the archive. We have 17 packages using $all, 2 are sysvinit
specific, 4 have a native service file, so the remaining 11 are
potential candidates.

The idea of using After=multi-user.target is interesting. I probably
wouldn't complain if a patch for that was applied.

On the other hand, for the few packages remaining still shipping SysV
init scripts only, those could just add native service files.


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
1  bootchart/init.d/bootchart:# Required-Start:    $remote_fs $all
2  cardstories/init.d/cardstories:# Required-Start:    $all
   cardstories/init.d/cardstories:# Required-Stop:     $all
3  debian-edu-install/init.d/xdebian-edu-firstboot:# Required-Start:    $remote_fs $all
4  dhcp-probe/init.d/dhcp-probe:# Required-Start:    $local_fs $remote_fs $syslog $network $all
5  dtc-xen-firewall/init.d/dtc-xen-firewall:# Required-Start:    $remote_fs $all
   dtc-xen/init.d/dtc-xen:# Required-Start:    $all
6  monit/init.d/monit:# Should-Start:      $all
   monit/init.d/monit:# Should-Stop:       $all
7  reniced/init.d/reniced:# Required-Start:    $all
8  syslog-nagios-bridge/init.d/syslog-nagios-bridge:# Required-Start:    $all
   syslog-nagios-bridge/init.d/syslog-nagios-bridge:# Required-Stop:     $all
9  torque-scheduler/init.d/torque-scheduler:# Required-Start:    $all
   torque-scheduler/init.d/torque-scheduler:# Required-Stop:     $all
   torque-scheduler/init.d/torque-scheduler:# Should-Start:      $all
   torque-scheduler/init.d/torque-scheduler:# Should-Stop:       $all
10 xymon-client/init.d/xymon-client:# Should-Start:      $all
11 xymon/init.d/xymon:# Should-Start:      $all

12 bootchart2/init.d/bootchart-done:# Required-Start:    $remote_fs $all
13 cloud-init/init.d/cloud-final:# Required-Start:    $all cloud-config
14 plymouth/init.d/plymouth:# Required-Start:	udev $remote_fs $all
15 watchdog/init.d/watchdog:# Required-Start:    $all
   watchdog/init.d/watchdog:# Required-Stop:     $all
   watchdog/init.d/wd_keepalive:# X-Start-Before:    $all

16 initscripts/init.d/rc.local:# Required-Start:    $all
   initscripts/init.d/rmnologin:# Required-Start:    $remote_fs $all
   initscripts/init.d/single:# Required-Start:    $local_fs $all killprocs
17 bootlogd/init.d/stop-bootlogd:# Required-Start:    $local_fs $all
   bootlogd/init.d/stop-bootlogd-single:# Required-Start:    $local_fs $all

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20170109/2b8dd440/attachment-0002.sig>