Bug#851730: init-system-helpers: update-rc.d fails to disable nbd-server

[Felipe Sateler]

On 17 January 2017 at 23:52, Christoph Anton Mitterer
<calestyo at scientia.net> wrote:
> Package: init-system-helpers
> Version: 1.46
> Severity: important
>
> Hi.
>
> Not sure why the following happens:
> # update-rc.d nbd-server disable
> update-rc.d: error: nbd-server Default-Start contains no runlevels, aborting.

This is caused because update-rc.d parses Default-Start:

    if (m/^### BEGIN INIT INFO$/) {

But the nbd-server initscript has trailing whitespace.

I wonder if update-rc.d should relax the match to not include the line
ending. For reference, both the systemd sysv-generator and insserv
have such a relaxed parsing:

https://sources.debian.net/src/systemd/232-10/src/sysv-generator/sysv-generator.c/#L495
https://sources.debian.net/src/insserv/1.14.0-5.4/insserv.c/#L1309

I'm inclined to make update-rc.d agree with insserv and systemd; opinions?

-- 

Saludos,
Felipe Sateler