Bug#791944: /etc/init.d/sendsigs kills systemd-udevd upon shutdown, causing dmsetup to hang

[Felipe Sateler]

Control: retitle -1 udev does not close the control socket on stop under sysvinit

On Sat, Jun 3, 2017 at 4:31 AM, Guilhem Moulin <guilhem at debian.org> wrote:
>
> On Mon, 29 May 2017 at 14:42:33 +0200, Michael Biebl wrote:
> > tags 791944 + help
>
> I'm afraid I can't help backporting the fix to Stretch, but as Pali
> mentioned this bug causes a severe regression for sysvinit users with
> encrypted disks.
>
> If udev can't be fixed in time maybe cryptsetup could ship a workaround
> instead (although I don't know whether the regression affects other
> dm-related services as well, such as mdadm or lvm).  I'm wondering if
> the udev maintainers have any opinion on the following patch and
> possible regressions.
>
> --8<--------------------------------------------------------------------->8--
> diff --git a/debian/cryptdisks.init b/debian/cryptdisks.init
> index 286bc18..166122c 100644
> --- a/debian/cryptdisks.init
> +++ b/debian/cryptdisks.init
> @@ -36,6 +36,7 @@ start)
>         do_start
>         ;;
>  stop)
> +       /etc/init.d/udev status >/dev/null || rm -f /run/udev/control
>         do_stop
>         ;;
>  restart|reload|force-reload)
> --8<--------------------------------------------------------------------->8--
>
> Pali, could you confirm that it fixes the shutdown freeze on your
> system?

This is an ugly fix. The correct one would be to have the udev
initscript do the same the systemd units do: remove the socket on
stop:

diff --git a/debian/udev.init b/debian/udev.init
index ffef3ea6a..dcc5c29d5 100644
--- a/debian/udev.init
+++ b/debian/udev.init
@@ -208,6 +208,7 @@ case "$1" in
     stop)
     log_daemon_msg "Stopping $DESC" "$NAME"
     if start-stop-daemon --stop --name $NAME --user root --quiet --oknodo --retry 5; then
+	rm -f /run/udev/control
 	log_end_msg $?
     else
 	log_end_msg $?


Could you test if this fixes the issue?

-- 

Saludos,
Felipe Sateler