Bug#879771: init-system-helpers: update-rc.d falsly creates K-symlinks on installation which breaks switching init systems later

[Felipe Sateler]

Control: tags -1 pending

Hi Daniel,

On Wed, Oct 25, 2017 at 1:13 PM, Daniel Reichelt <debian at nachtgeist.net> wrote:
> Package: init-system-helpers
> Version: 1.50
> Severity: important
> Tags: patch
>
> Hi,
>
> Assume this environment:
>
> - debootstrap sid
> - chroot apt-get install openssh-server
>
>
> With init-system-helpers <1.50 you would now find S-symlinks in
> etc/rc?.d. However with init-system-helpers 1.50, you'll see erroneously
> created K-symlinks - which doesn't matter, systemd being used for init -
> but...
>
> ...if you were now to switch the init system to sysv-rc or openrc,
> update-rc.d would see the kill-symlinks, think they had been disabled by
> the user and not touch them any further. This most likely leaves any
> server system unusable after a reboot, ifupdown (/etc/init.d/networking)
> or any other init-script-carrying package being affected as well.
>
>
> Please find attached a patch for the update-rc.d script.

Thanks for the patch! I was notified earlier today about the problem, and
discussion and had produced the same patch[1].

I am in the process of uploading now.

Next in the TODO: add some autopkgtests....

[1] https://anonscm.debian.org/git/collab-maint/init-system-helpers.git/commit/?id=7b4318cb2238c21dca86ab5e3bb4429309b4cf1b

-- 

Saludos,
Felipe Sateler