Bug#887904: RFR: Make dh_installinit and dh_installsystemd debhelper autoscript snippets independent in c12 (Was: Re: Bug#887904: dh_installsystemd will unmask services *after* an attempt to start them)

[Felipe Sateler]

On Sun, May 13, 2018 at 11:34 AM Niels Thykier <niels at thykier.net> wrote:

> Control: tags -1 patch
>
> On Sun, 21 Jan 2018 16:45:47 +0100 Michael Biebl <biebl at debian.org> wrote:
> > [...]
> >
> > See the generated postinst script.
> >
> > The more I think about these ordering issues, the more I'm convinced
> > that for services which ship both a native service file and a systemd
> > service file, we should leave the start/stop/restart of the service to
> > dh_installsystemd/deb-systemd-invoke and only use the  invoke-rc.d call
> > on sysvinit systems.
>
> I have created a patch that ensures that dh_installsystemd's snippet are
> used for start/stop/restart iff the system is running systemd.
> Otherwise, the dh_installinit version handles start/stop/restart.
>
>  * I would welcome a review of this branch before I merge it, so we do
>    not end up with another "incomplete split" like we had with compat
>    11.
>

There is one case where I think things go wrong (but I haven't tested): A
package including only an init script will not run invoke-rc.d but it won't
have a dh_installsystemd snippet either, so the service won't get started
on installation.



-- 

Saludos,
Felipe Sateler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20180513/10816904/attachment-0002.html>