Bug#907845: Warn if compat level 11 is used and dh_system_* helpers are used

[Michael Biebl]

Package: lintian
Version: 2.5.99
Severity: wishlist

Hi,

in compat level 11, dh_systemd_start and dh_systemd_enable have been
deprecated in favour of dh_installsystemd.
dh will also no longer run the dh_systemd_{start,enable} helpers during
build.
I've seen a couple of packages which have updated their compat level to
11 but still use a dh_systemd_{start,enable} override.
It would be nice if lintian could detect (grep for usage of
override_dh_systemd_{start,enable} in debian/rules) and warn accordingly.

Regards,
Michael


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                       2.31.1-5
ii  bzip2                          1.0.6-9
ii  diffstat                       1.61-1+b1
ii  dpkg                           1.19.0.5+b1
ii  file                           1:5.34-2
ii  gettext                        0.19.8.1-7
ii  intltool-debian                0.35.0+20060710.4
ii  libapt-pkg-perl                0.1.34
ii  libarchive-zip-perl            1.63-1
ii  libclass-accessor-perl         0.51-1
ii  libclone-perl                  0.39-1
ii  libdigest-sha-perl             6.02-1
ii  libdpkg-perl                   1.19.0.5
ii  libemail-valid-perl            1.202-1
ii  libfile-basedir-perl           0.08-1
ii  libipc-run-perl                20180523.0-1
ii  liblist-moreutils-perl         0.416-1+b3
ii  libparse-debianchangelog-perl  1.2.0-12
ii  libtext-levenshtein-perl       0.13-1
ii  libtimedate-perl               2.3000-2
ii  liburi-perl                    1.74-1
ii  libxml-simple-perl             2.25-1
ii  libyaml-libyaml-perl           0.72+repack-1
ii  man-db                         2.8.4-2
ii  patchutils                     0.3.4-2
ii  perl [libdigest-sha-perl]      5.26.2-7
ii  t1utils                        1.41-2
ii  xz-utils                       5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.19.0.5
ii  libhtml-parser-perl    3.72-3+b2
ii  libtext-template-perl  1.53-1

-- no debconf information