Bug#909455: systemd FTBFS: meson_options.txt:49:0: ERROR: Option name debug is reserved.

[Helmut Grohne]

Source: systemd
Version: 239-9
Severity: serious
Tags: ftbfs
User: helmutg at debian.org
Usertags: rebootstrap
Control: reassign 909440 meson
Control: tags 909440 + ftbfs
Control: affects 909440 + src:systemd
Control: block -1 by 909440

systemd presently fails to build from source. The immediate reason is
that meson lacks a dependency on python3-pkg-resources. That problem can
be worked around e.g. by adding --add-depends=python3-pkg-resources to
an sbuild invocation. The missing dependency is already properly tracked
and not subject of this bug.

Once you work around the issue, systemd fails to build in a novel way:

| make[1]: Entering directory '/<<PKGBUILDDIR>>'
| dh_auto_configure --builddirectory=build-deb \
|         -- -Db_lto=true -Drootlibdir=/lib/x86_64-linux-gnu -Dsplit-usr=true -Dquotaon-path=/sbin/quotaon -Dquotacheck-path=/sbin/quotacheck -Dkmod-path=/bin/kmod -Dkexec-path=/sbin/kexec -Dsulogin-path=/sbin/sulogin -Dmount-path=/bin/mount -Dumount-path=/bin/umount -Dloadkeys-path=/bin/loadkeys -Dsetfont-path=/bin/setfont -Dtelinit-path=/lib/sysvinit/telinit -Dsysvinit-path=/etc/init.d -Dsysvrcnd-path=/etc -Ddebug-shell=/bin/bash -Dzshcompletiondir=/usr/share/zsh/vendor-completions -Ddbuspolicydir=/usr/share/dbus-1/system.d/ -Dsupport-url=https://www.debian.org/support -Ddefault-kill-user-processes=false -Dpamconfdir=no -Drpmmacrosdir=no -Dqrencode=false -Dvconsole=false -Dfirstboot=false -Dxkbcommon=false -Dportabled=false -Dwheel-group=false -Dntp-servers="0.debian.pool.ntp.org 1.debian.pool.ntp.org 2.debian.pool.ntp.org 3.debian.pool.ntp.org" -Dlink-udev-shared=false -Dsystem-uid-max=999 -Dsystem-gid-max=999 -Dnobody-user=nobody -Dnobody-group=nogroup -Ddev-kvm-mode=0660   -Dselinux=true -Dhwdb=true -Dsysusers=true -Dinstall-tests=true -Defi=true -Dnss-systemd=true -Dresolve=true -Daudit=true -Dlibcryptsetup=true -Dcoredump=true -Delfutils=true -Dapparmor=true -Dlibidn=true -Dlibiptc=true -Dlibcurl=true -Dimportd=true -Dmicrohttpd=true -Dgnutls=true
|         cd build-deb && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu -Db_lto=true -Drootlibdir=/lib/x86_64-linux-gnu -Dsplit-usr=true -Dquotaon-path=/sbin/quotaon -Dquotacheck-path=/sbin/quotacheck -Dkmod-path=/bin/kmod -Dkexec-path=/sbin/kexec -Dsulogin-path=/sbin/sulogin -Dmount-path=/bin/mount -Dumount-path=/bin/umount -Dloadkeys-path=/bin/loadkeys -Dsetfont-path=/bin/setfont -Dtelinit-path=/lib/sysvinit/telinit -Dsysvinit-path=/etc/init.d -Dsysvrcnd-path=/etc -Ddebug-shell=/bin/bash -Dzshcompletiondir=/usr/share/zsh/vendor-completions -Ddbuspolicydir=/usr/share/dbus-1/system.d/ -Dsupport-url=https://www.debian.org/support -Ddefault-kill-user-processes=false -Dpamconfdir=no -Drpmmacrosdir=no -Dqrencode=false -Dvconsole=false -Dfirstboot=false -Dxkbcommon=false -Dportabled=false -Dwheel-group=false "-Dntp-servers=0.debian.pool.ntp.org 1.debian.pool.ntp.org 2.debian.pool.ntp.org 3.debian.pool.ntp.org" -Dlink-udev-shared=false -Dsystem-uid-max=999 -Dsystem-gid-max=999 -Dnobody-user=nobody -Dnobody-group=nogroup -Ddev-kvm-mode=0660 -Dselinux=true -Dhwdb=true -Dsysusers=true -Dinstall-tests=true -Defi=true -Dnss-systemd=true -Dresolve=true -Daudit=true -Dlibcryptsetup=true -Dcoredump=true -Delfutils=true -Dapparmor=true -Dlibidn=true -Dlibiptc=true -Dlibcurl=true -Dimportd=true -Dmicrohttpd=true -Dgnutls=true
| The Meson build system
| Version: 0.48.0
| Source dir: /<<PKGBUILDDIR>>
| Build dir: /<<PKGBUILDDIR>>/build-deb
| Build type: native build
| 
| meson_options.txt:49:0: ERROR:  Option name debug is reserved.
| 
| A full log can be found at /<<PKGBUILDDIR>>/build-deb/meson-logs/meson-log.txt
|         cd build-deb && tail -v -n \+0 meson-logs/meson-log.txt
| ==> meson-logs/meson-log.txt <==
| Build started at 2018-09-24T03:40:26.699787
| Main binary: /usr/bin/python3
| Python system: Linux
| The Meson build system
| Version: 0.48.0
| Source dir: /<<PKGBUILDDIR>>
| Build dir: /<<PKGBUILDDIR>>/build-deb
| Build type: native build
| 
| meson_options.txt:49:0: ERROR:  Option name debug is reserved.
| dh_auto_configure: cd build-deb && LC_ALL=C.UTF-8 meson .. --wrap-mode=nodownload --buildtype=plain --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=lib/x86_64-linux-gnu --libexecdir=lib/x86_64-linux-gnu -Db_lto=true -Drootlibdir=/lib/x86_64-linux-gnu -Dsplit-usr=true -Dquotaon-path=/sbin/quotaon -Dquotacheck-path=/sbin/quotacheck -Dkmod-path=/bin/kmod -Dkexec-path=/sbin/kexec -Dsulogin-path=/sbin/sulogin -Dmount-path=/bin/mount -Dumount-path=/bin/umount -Dloadkeys-path=/bin/loadkeys -Dsetfont-path=/bin/setfont -Dtelinit-path=/lib/sysvinit/telinit -Dsysvinit-path=/etc/init.d -Dsysvrcnd-path=/etc -Ddebug-shell=/bin/bash -Dzshcompletiondir=/usr/share/zsh/vendor-completions -Ddbuspolicydir=/usr/share/dbus-1/system.d/ -Dsupport-url=https://www.debian.org/support -Ddefault-kill-user-processes=false -Dpamconfdir=no -Drpmmacrosdir=no -Dqrencode=false -Dvconsole=false -Dfirstboot=false -Dxkbcommon=false -Dportabled=false -Dwheel-group=false "-Dntp-servers=0.debian.pool.ntp.org 1.debian.pool.ntp.org 2.debian.pool.ntp.org 3.debian.pool.ntp.org" -Dlink-udev-shared=false -Dsystem-uid-max=999 -Dsystem-gid-max=999 -Dnobody-user=nobody -Dnobody-group=nogroup -Ddev-kvm-mode=0660 -Dselinux=true -Dhwdb=true -Dsysusers=true -Dinstall-tests=true -Defi=true -Dnss-systemd=true -Dresolve=true -Daudit=true -Dlibcryptsetup=true -Dcoredump=true -Delfutils=true -Dapparmor=true -Dlibidn=true -Dlibiptc=true -Dlibcurl=true -Dimportd=true -Dmicrohttpd=true -Dgnutls=true returned exit code 1
| make[1]: *** [debian/rules:155: override_dh_auto_configure] Error 2
| make[1]: Leaving directory '/<<PKGBUILDDIR>>'
| make: *** [debian/rules:292: binary] Error 2
| dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

I'm unsure whether this is a problem in meson or systemd, but reporting
it seems like the obvious first step. Meson maintainers Cced.

I note that I am repeatedly less than impressed by the quality of meson
uploads. The number of times that a meson uploads has broken systemd is
annoying. The number of times a fatal failure could have been avoided
with simple pre-upload checks (e.g. building systemd, diffing contents
to the previous version, checking the github issue tracker for reported
regressions) is roughly equal. I'm not objection to the occasional
screwup. Shit happens. We learn from our mistakes, but it sometimes
looks as if meson maintenance does not learn.

Helmut