Bug#926927: Please add iptables.service and ip6tables.service symlinks

[Laurent Bigonville]

Package: iptables-persistent
Version: 1.0.12
Severity: normal
Tags: patch

Hi,

In other distributions, (mainly RH/Fedora) their equivalant package
(iptables-services) is installing systemd iptables.service and
ip6tables.service files.

Some other services (like firewalld) are using these in their own
.service file as dependency or conflict

Would be nice if iptables-persistent was adding symlinks so other
services doesn't need to be modified

Kind regards,
Laurent Bigonville

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.0.0-trunk-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru iptables-persistent-1.0.12/debian/ipset-persistent.lintian-overrides iptables-persistent-1.0.12bigon1/debian/ipset-persistent.lintian-overrides
--- iptables-persistent-1.0.12/debian/ipset-persistent.lintian-overrides	1970-01-01 01:00:00.000000000 +0100
+++ iptables-persistent-1.0.12bigon1/debian/ipset-persistent.lintian-overrides	2019-04-12 12:11:09.000000000 +0200
@@ -0,0 +1,3 @@
+# netfilter-persistent.service is installed in the netfilter-persistent package
+# and this package directly depends on it
+ipset-persistent: service-file-is-not-a-file lib/systemd/system/ipset.service
diff -Nru iptables-persistent-1.0.12/debian/iptables-persistent.lintian-overrides iptables-persistent-1.0.12bigon1/debian/iptables-persistent.lintian-overrides
--- iptables-persistent-1.0.12/debian/iptables-persistent.lintian-overrides	1970-01-01 01:00:00.000000000 +0100
+++ iptables-persistent-1.0.12bigon1/debian/iptables-persistent.lintian-overrides	2019-04-12 12:11:09.000000000 +0200
@@ -0,0 +1,4 @@
+# netfilter-persistent.service is installed in the netfilter-persistent package
+# and this package directly depends on it
+iptables-persistent: service-file-is-not-a-file lib/systemd/system/ip6tables.service
+iptables-persistent: service-file-is-not-a-file lib/systemd/system/iptables.service
diff -Nru iptables-persistent-1.0.12/debian/rules iptables-persistent-1.0.12bigon1/debian/rules
--- iptables-persistent-1.0.12/debian/rules	2019-03-27 07:34:28.000000000 +0100
+++ iptables-persistent-1.0.12bigon1/debian/rules	2019-04-12 12:11:09.000000000 +0200
@@ -2,3 +2,11 @@
 
 %:
 	dh $@
+
+override_dh_installsystemd:
+	# install the symlinks before calling dh_installsystemd, using a .links
+	# file will not work as dh_link is called later in the sequence
+	dh_link -pipset-persistent lib/systemd/system/netfilter-persistent.service lib/systemd/system/ipset.service
+	dh_link -piptables-persistent lib/systemd/system/netfilter-persistent.service lib/systemd/system/iptables.service
+	dh_link -piptables-persistent lib/systemd/system/netfilter-persistent.service lib/systemd/system/ip6tables.service
+	dh_installsystemd