Bug#934166: Please add lintian warning for systemd system services using default.target

[Michael Biebl]

Package: lintian
Version: 2.17.0
Severity: wishlist

Hi,

I noticed a couple of systemd system services
(files that match /lib/systemd/system/*.{service,socket,...})
that use

[Install]
Alias=default.target


default.target is only an alias and should not be used for that.
Instead services should either hook into multi-user.target (for the vast
majority this is the right choice) or graphical.target.

It would be a good idea if lintian would add a warning for this.

For user level services (files matching
/usr/lib/systemd/user/*.{service,socket,...}) the situation is a bit different.
There, using default.target is correct, as default.target is not an
alias. In a user level systemd, there is not distinction between
graphical.target and multi-user.target.


Regards


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                     2.32.51.20190727-1
ii  bzip2                        1.0.6-9.2
ii  diffstat                     1.62-1+b1
ii  dpkg                         1.19.7
ii  dpkg-dev                     1.19.7
ii  file                         1:5.37-5
ii  gettext                      0.19.8.1-9
ii  gpg                          2.2.17-3
ii  intltool-debian              0.35.0+20060710.5
ii  libapt-pkg-perl              0.1.36+b1
ii  libarchive-zip-perl          1.64-1
ii  libcapture-tiny-perl         0.48-1
ii  libcgi-pm-perl               4.44-1
ii  libclass-accessor-perl       0.51-1
ii  libclone-perl                0.41-1+b1
ii  libdigest-sha-perl           6.02-1+b1
ii  libdpkg-perl                 1.19.7
ii  libemail-valid-perl          1.202-1
ii  libfile-basedir-perl         0.08-1
ii  libfile-find-rule-perl       0.34-1
ii  libio-async-loop-epoll-perl  0.20-1
ii  libio-async-perl             0.74-1
ii  libipc-run-perl              20180523.0-1
ii  liblist-compare-perl         0.53-1
ii  liblist-moreutils-perl       0.416-1+b4
ii  libmoo-perl                  2.003004-2
ii  libpath-tiny-perl            0.108-1
ii  libtext-levenshtein-perl     0.13-1
ii  libtimedate-perl             2.3000-2
ii  libtry-tiny-perl             0.30-1
ii  libtype-tiny-perl            1.004004-1
ii  liburi-perl                  1.76-1
ii  libxml-simple-perl           2.25-1
ii  libyaml-libyaml-perl         0.79+repack-2
ii  man-db                       2.8.6.1-1
ii  patchutils                   0.3.4-2+b1
ii  perl                         5.28.1-6
ii  t1utils                      1.41-3
ii  xz-utils                     5.2.4-1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b5

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libhtml-parser-perl    3.72-3+b3
ii  libtext-template-perl  1.55-1

-- no debconf information