Bug#944586: udev: after upgrading to version 243-5, udev blocks the removal of lvm2 snapshots

[gregor herrmann]

On Tue, 12 Nov 2019 14:50:51 +0100, Michael Biebl wrote:

> > and a associated PR
> > https://github.com/systemd/systemd/pull/13984
> > Could you test if that patch helps?
> We already have one confirmation (upstream) that this PR helps, but it's
> always better to have explicit confirmation

Thanks for looking into this issue so quickly and for finding this
pull request!

I've now rebuilt systemd with the pull request as an additional
quilt patch, and installed udev and libudev1.


/*
One interesting phenomenon which I also saw yesterday with 243-5 is
that "udevadm trigger" has less output (sdc is an external USB
harddrive with luks+lvm on it).

With 242-8:

# udevadm trigger --settle --verbose --action=add /dev/sdc
/sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc
/sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc/sdc1
settle /sys/devices/virtual/block/dm-5
settle /sys/devices/virtual/block/dm-6
settle /sys/devices/virtual/block/dm-7
settle /sys/devices/virtual/block/dm-2
settle /sys/devices/virtual/block/dm-1
settle /sys/devices/virtual/block/dm-3
settle /sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc
settle /sys/devices/virtual/block/dm-5
settle /sys/devices/virtual/block/dm-6
settle /sys/devices/virtual/block/dm-7
settle /sys/devices/virtual/block/dm-1
settle /sys/devices/virtual/block/dm-2
settle /sys/devices/virtual/block/dm-3
settle /sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc/sdc1

With 243-5 with or without the patch:

# udevadm trigger --settle --verbose --action=add /dev/sdc
/sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc
/sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc/sdc1
settle /sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc
settle /sys/devices/pci0000:00/0000:00:1a.0/usb1/1-1/1-1.1/1-1.1.2/1-1.1.2:1.0/host5/target5:0:0/5:0:0:0/block/sdc/sdc1

(No idea if the missing block/dm-X lines are relevant …)
*/


Anyway, back to the lvremove issue; I have a few packages to upload
anyway, so I can test autopkgtest with schroot and LVM snapshots in
production :)

I have now run autopkgtest(-pkg-perl) on 5 packages, that means 15
creations and removals of LVM snapshots, and I haven't encountered
any issues. So yes, this patch looks good.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Janis Joplin: Kozmic Blues
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20191112/d5ab4864/attachment.sig>