Bug#955483: Alphanumeric ordering of depending sockets breaks restart

[Guido Günther]

Hi,
On Thu, Apr 02, 2020 at 10:18:53AM +0200, Michael Biebl wrote:
> Control: tags -1 + moreinfo unreproducible
> 
> Am 02.04.20 um 09:52 schrieb Guido Günther:
> > control: reassign -1 systemd
> > control: retitle -1 systemd fails to restart socket unit of already running service
>

you have:

> 
> root at pluto:~# systemctl status libvirtd.service libvirtd.socket
> ● libvirtd.service - Virtualization daemon
>      Loaded: loaded (/lib/systemd/system/libvirtd.service; disabled;
> vendor prese>
>      Active: inactive (dead)
> TriggeredBy: ● libvirtd.socket
>              ● libvirtd-ro.socket
>              ● libvirtd-admin.socket
>        Docs: man:libvirtd(8)
>              https://libvirt.org

service not running but

> 
> ● libvirtd.socket - Libvirt local socket
>      Loaded: loaded (/lib/systemd/system/libvirtd.socket; enabled;
> vendor preset:>
>      Active: active (listening) since Thu 2020-04-02 10:17:40 CEST; 24s ago
>    Triggers: ● libvirtd.service
>      Listen: /run/libvirt/libvirt-sock (Stream)
>      CGroup: /system.slice/libvirtd.socket

socket running. I'm talking about the other way around (service running
then restarting socket).

# systemctl status libvirtd.service libvirtd.socket
● libvirtd.service - Virtualization daemon
     Loaded: loaded (/lib/systemd/system/libvirtd.service; enabled; vendor preset: enabled)
     Active: active (running) since Thu 2020-04-02 09:44:39 CEST; 49min ago
TriggeredBy: ● libvirtd-admin.socket
             ● libvirtd.socket
             ● libvirtd-ro.socket
       Docs: man:libvirtd(8)
             https://libvirt.org
   Main PID: 484267 (libvirtd)
      Tasks: 19 (limit: 32768)
     Memory: 31.6M
     CGroup: /system.slice/libvirtd.service
             ├─  1538 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/lib/libvirt/libvirt_leaseshelper
             ├─  1539 /usr/sbin/dnsmasq --conf-file=/var/lib/libvirt/dnsmasq/default.conf --leasefile-ro --dhcp-script=/usr/lib/libvirt/libvirt_leaseshelper
             └─484267 /usr/sbin/libvirtd

Apr 02 09:44:39 foo systemd[1]: Starting Virtualization daemon...
Apr 02 09:44:39 foo systemd[1]: Started Virtualization daemon.
Apr 02 09:44:39 foo dnsmasq[1538]: read /etc/hosts - 6 addresses
Apr 02 09:44:39 foo dnsmasq[1538]: read /var/lib/libvirt/dnsmasq/default.addnhosts - 0 addresses
Apr 02 09:44:39 foo dnsmasq-dhcp[1538]: read /var/lib/libvirt/dnsmasq/default.hostsfile

● libvirtd.socket - Libvirt local socket
     Loaded: loaded (/lib/systemd/system/libvirtd.socket; enabled; vendor preset: enabled)
     Active: active (running) since Thu 2020-04-02 09:44:39 CEST; 49min ago
   Triggers: ● libvirtd.service
     Listen: /run/libvirt/libvirt-sock (Stream)
     CGroup: /system.slice/libvirtd.socket

Apr 02 09:44:39 foo systemd[1]: Listening on Libvirt local socket.
root at foo:/var/scratch/src/libvirt/libvirt# systemctl restart libvirtd.socket
Job failed. See "journalctl -xe" for details.

Cheers,
 -- Guido
> 
> Apr 02 10:17:40 pluto systemd[1]: libvirtd.socket: Succeeded.
> Apr 02 10:17:40 pluto systemd[1]: Closed Libvirt local socket.
> Apr 02 10:17:40 pluto systemd[1]: Stopping Libvirt local socket.
> Apr 02 10:17:40 pluto systemd[1]: Listening on Libvirt local socket.
> 
> 
> root at pluto:~# systemctl restart libvirtd.socket
> root at pluto:~# echo $?
> 0
>