Bug#954312: systemd: FTBFS on riscv64: test-seccomp fails: Assertion 'name' failed at src/test/test-seccomp.c:49

[Aurelien Jarno]

Package: systemd
Version: 245.2-1
Severity: normal
Tags: patch

Dear maintainer,

The latest version of systemd enabled seccomp support on riscv64. Thanks
for doing that. However it now fails to build due to the test
test-seccomp failing:

| 321/486 test-seccomp                            FAIL     0.09 s (killed by signal 6 SIGABRT)
| 
| --- command ---
| 08:37:44 PATH='/<<PKGBUILDDIR>>/build-deb:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games' SYSTEMD_KBD_MODEL_MAP='/<<PKGBUILDDIR>>/src/locale/kbd-model-map' SYSTEMD_LANGUAGE_FALLBACK_MAP='/<<PKGBUILDDIR>>/src/locale/language-fallback-map' /<<PKGBUILDDIR>>/build-deb/test-seccomp
| --- stderr ---
| Failed to read $container of PID 1, ignoring: Permission denied
| Found container virtualization none.
| /* test_seccomp_arch_to_string */
| Assertion 'name' failed at src/test/test-seccomp.c:49, function test_seccomp_arch_to_string(). Aborting.
| -------

The full build log is available there:
https://buildd.debian.org/status/fetch.php?pkg=systemd&arch=riscv64&ver=245.2-1&stamp=1584607125&raw=0

It happens that upstream systemd doesn't support yet riscv64. I came
with a very simple patch to fix that issue:

--- systemd-245.2.orig/src/test/test-seccomp.c
+++ systemd-245.2/src/test/test-seccomp.c
@@ -72,6 +72,7 @@ static void test_architecture_table(void
                        "ppc\0"
                        "ppc64\0"
                        "ppc64-le\0"
+                       "riscv64\0"
                        "s390\0"
                        "s390x\0") {
                 uint32_t c;

With this patch, test-seccomp pass successfully and the build succeed.
I have also tested that after installing the resulting seccomp package
the systemd boots and works fine with kernel 5.4 (i.e. without seccomp
support) and kernel 5.5 (i.e. with seccomp support).

Therefore, would it be possible to add this patch in the next upload?

Thanks,
Aurelien

-- Package-specific info:

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-3-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE=fr (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
- no debconf information