Bug#970213: systemd: kernel/install.d/85-initrd.install: Please don't duplicate initrd in ESP when an explicit one was passed

[Michael Biebl]

Am 13.09.20 um 04:48 schrieb наб:
> Package: systemd
> Version: 246.4-1
> Severity: wishlist
> Tags: patch
> 
> Dear Maintainer,
> 
> kernel/install.d/85-initrd.install installs /boot/initrd.img-$VER
> to ESP/$MID/$VER/initrd unconditionally, even when an explicit path was
> passed.
> 
> However, upstream's 90-loaderentry.install already does this,
> and installs the initrds it gets to their basenames under ESP/$MID/$VER/
> 
> This means, that by default, when running
>   kernel-install add $(uname -r) /boot/vmlinuz-$(uname -r) /boot/initrd.img-$(uname -r)
> a new installation produced
>   /boot/efi/62dd03a4928c412180b3024ac6c03a90/5.8.0-1-amd64/linux
>   /boot/efi/62dd03a4928c412180b3024ac6c03a90/5.8.0-1-amd64/initrd
>   /boot/efi/62dd03a4928c412180b3024ac6c03a90/5.8.0-1-amd64/initrd.img-5.8.0-1-amd64
> with a configuration pointing to the latter initrd,
> this is wasteful at best and confusing at worst.
> 
> This doesn't break the case of no initrd being specified,
> since 90-loaderentry.install falls back to ESP/$MID/$VER/initrd,
> and that's the point of this.
> 
> Attached is patch for this and another one to match the installation
> process and (partially) messages to 90-loaderentry.install's.


Thanks for the patch(es). If it's not too much trouble, can you create a
pull request on https://salsa.debian.org/systemd-team/systemd ?

@Martin: I assume you are more familiar with this  kernel-install hook:
https://salsa.debian.org/systemd-team/systemd/commit/c41ccefc

Could you have a look?

Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20200913/b3bbb4ff/attachment.sig>