Bug#993248: machinectl fails to bind mount a directory into a container

[Michael Biebl]

Control: tags -1 + patch fixed-upstream


Am 30.08.21 um 14:33 schrieb Michael Biebl:

> This seems to work fine with
> 249.3-4 from experimental. So marking as fixed for that version.
> 
> If you are interested in seeing this fixed in bullseye, it would be 
> great if you can run git bisect to find the commit that fixed it.
> If it's reasonable enough, we might consider backporting it.
> 

I ran a git bisect. The first commit fixing it is

commit 98f654fdeab1e1b6df2be76e29e4ccbb6624898d
Author: Luca Boccassi <bluca at debian.org>
Date:   Wed Jan 13 23:52:00 2021 +0000

     machine: enter target PID namespace when adding a live mount

     machinectl fails since 21935150a0c42b91a322105f6a9129116bfc8e2e as 
it's now
     mounting onto a file descriptor in a target namespace, without 
joining the
     target's PID namespace.
     Note that it's not enough to setns CLONE_NEWPID, but a double-fork 
is required
     as well, as implemented by namespace_fork().

     Add a test case to TEST-13-NSPAWN to cover this use case.


Attached is a backport of the relevant commits from
https://github.com/systemd/systemd/pull/17228

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-basic-add-make_mount_point_inode-helper.patch
Type: text/x-patch
Size: 9461 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20210901/54a51f86/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-machine-basic-factor-out-helper-function-to-add-airl.patch
Type: text/x-patch
Size: 19989 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20210901/54a51f86/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-machine-adjust-error-message-to-use-normalized-inste.patch
Type: text/x-patch
Size: 1512 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20210901/54a51f86/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-shared-mount-util-use-namespace_fork-utils.patch
Type: text/x-patch
Size: 4109 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20210901/54a51f86/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-machine-enter-target-PID-namespace-when-adding-a-liv.patch
Type: text/x-patch
Size: 4109 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20210901/54a51f86/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20210901/54a51f86/attachment-0001.sig>