Bug#1014115: uninstall does not properly remove enablement symlinks

[Michael Biebl]

Control: clone -1 -2
Control: reassign -2 init-system-helpers
Control: retitle -2 deb-systemd-helper fails with circular Also=
Control: found -2 1.63
Control: severity -1 serious
Control: tags -1 + patch

Am 30.06.22 um 14:26 schrieb Michael Biebl:
> This might be a bug in i-s-h, but filing against systemd-homed for
> now.
> 
> systemd-homed.service:
> [Install]
> WantedBy=multi-user.target
> Alias=dbus-org.freedesktop.home1.service
> Also=systemd-homed-activate.service systemd-userdbd.service
> 
> systemd-homed-activate.service:
> [Install]
> WantedBy=systemd-homed.service
> Also=systemd-homed.service
> 
> → we have a circular dependency here, maybe deb-systemd-helper get's
> confused by that


I just checked that we can mitigate this issue by removing this circular 
Also= dependency. It is indeed deb-systemd-helper getting confused by 
that and as a result not writing proper state files to 
/var/lib/systemd/deb-systemd-helper.
So the damage is already done during installation in postinst.
Thus raising to RC to warn users from installing systemd-homed atm.

I propose a patch like the attached one, i.e. dropping the Also= from 
systemd-homed-active.service. WDYT?

I've also cloned the issue for i-s-h, as we might want to fix that 
properly. My perl is a bit rusty, so would appreciate help with that.

@bluca: do you think the attached patch is suitable for upstream?

I find this circular Also= dependency kinda odd, I have to admit.

Regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-circular-Also-dependency-for-systemd-homed.patch
Type: text/x-patch
Size: 635 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20220630/719a5bab/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20220630/719a5bab/attachment.sig>