Bug#1021644: logind: OnExternalPower is confusedj

[Michael Biebl]

Am 12.10.22 um 10:25 schrieb Michael Biebl:
> Hi Helmut,
> 
> I can reproduce the issue here.
> Since we don't ship any Debian specific patches in that regard, it would 
> be awesome if you can raise this upstream at
> 
> https://github.com/systemd/systemd/issues
> 
> I quickly searched through existing PRs and issues but didn't find 
> anything.
> 

Since I can reproduce the issue, I might just as well send a PR with 
your proposed change.


> Am 12.10.22 um 06:19 schrieb Helmut Grohne:
> There is a corresponding
> #define BUS_DEFINE_PROPERTY_GET(function, bus_type, data_type, get1)
> where "get1" is interpreted as a function. This inconsistency between 
> those two macros is a bit of a pitfall I assume.
> 
> A "grep BUS_DEFINE_PROPERTY_GET_GLOBAL -R" doesn't reveal any other 
> occurrences where this might be wrong. So it might just be the one spot 
> that you found.

What I meant here is:

static BUS_DEFINE_PROPERTY_GET(property_get_docked, "b", Manager, 
manager_is_docked_or_external_displays);
→ no () required


static BUS_DEFINE_PROPERTY_GET_GLOBAL(property_get_on_external_power, 
"b", manager_is_on_external_power);
→ () required. Since they are right next to each other, it's easy to get 
wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-systemd-maintainers/attachments/20221012/0ddeb4fa/attachment.sig>