Bug#1051760: upstream autopgtest fails due to missing tzdata-legacy

[Michael Biebl]

Source: systemd
Version: 254.1-3
Severity: important

The upstream autopkgtest fails on Debian sid:

TEST-01-BASIC:                      FAIL     ( 55 s)
TEST-02-UNITTESTS:                  FAIL     (2401 s)
TEST-03-JOBS:                       FAIL     (  2 s)
TEST-04-JOURNAL:                    FAIL     (  2 s)
TEST-05-RLIMITS:                    FAIL     (  2 s)
TEST-06-SELINUX:                    SUCCESS  (  0 s)
TEST-07-PID1:                       FAIL     (  2 s)
TEST-13-NSPAWN:                     FAIL     ( 55 s)
TEST-15-DROPIN:                     FAIL     (  2 s)
TEST-16-EXTEND-TIMEOUT:             FAIL     (  1 s)
TEST-17-UDEV:                       FAIL     ( 54 s)
TEST-18-FAILUREACTION:              FAIL     (  2 s)
TEST-19-CGROUP:                     FAIL     (  1 s)
TEST-21-DFUZZER:                    SUCCESS  (  0 s)
TEST-22-TMPFILES:                   FAIL     (  3 s)
TEST-23-UNIT-FILE:                  FAIL     (  1 s)
TEST-24-CRYPTSETUP:                 FAIL     ( 57 s)
TEST-25-IMPORT:                     FAIL     (  2 s)
TEST-26-SYSTEMCTL:                  FAIL     (  1 s)
TEST-29-PORTABLE:                   FAIL     ( 60 s)
TEST-30-ONCLOCKCHANGE:              FAIL     ( 53 s)
TEST-31-DEVICE-ENUMERATION:         FAIL     ( 53 s)
TEST-32-OOMPOLICY:                  FAIL     ( 53 s)
TEST-34-DYNAMICUSERMIGRATE:         FAIL     (  2 s)
TEST-35-LOGIN:                      FAIL     (  2 s)
TEST-36-NUMAPOLICY:                 FAIL     ( 55 s)
TEST-38-FREEZER:                    FAIL     ( 53 s)
TEST-43-PRIVATEUSER-UNPRIV:         FAIL     (  4 s)
TEST-44-LOG-NAMESPACE:              FAIL     (  2 s)
TEST-45-TIMEDATE:                   FAIL     (  2 s)
TEST-46-HOMED:                      FAIL     (  2 s)
TEST-50-DISSECT:                    FAIL     ( 59 s)
TEST-52-HONORFIRSTSHUTDOWN:         FAIL     (107 s)
TEST-53-ISSUE-16347:                FAIL     ( 54 s)
TEST-54-CREDS:                      FAIL     (  2 s)
TEST-55-OOMD:                       FAIL     ( 57 s)
TEST-58-REPART:                     FAIL     ( 56 s)
TEST-59-RELOADING-RESTART:          FAIL     (  2 s)
TEST-60-MOUNT-RATELIMIT:            FAIL     (  2 s)
TEST-62-RESTRICT-IFACES:            FAIL     ( 54 s)
TEST-63-PATH:                       FAIL     (  2 s)
TEST-64-UDEV-STORAGE:               FAIL     (503 s)
TEST-65-ANALYZE:                    FAIL     (  2 s)
TEST-66-DEVICE-ISOLATION:           FAIL     ( 54 s)
TEST-67-INTEGRITY:                  FAIL     ( 59 s)
TEST-68-PROPAGATE-EXIT-STATUS:      FAIL     (  2 s)
TEST-69-SHUTDOWN:                   FAIL     (  3 s)
TEST-70-TPM2:                       FAIL     ( 59 s)
TEST-71-HOSTNAME:                   FAIL     (  2 s)
TEST-72-SYSUPDATE:                  FAIL     (  2 s)
TEST-73-LOCALE:                     FAIL     (  2 s)
TEST-74-AUX-UTILS:                  FAIL     (  2 s)
TEST-75-RESOLVED:                   FAIL     (  3 s)
TEST-76-SYSCTL:                     FAIL     (  2 s)
TEST-77-OPENFILE:                   FAIL     (  2 s)
TEST-78-SIGQUEUE:                   SUCCESS  (  2 s)
TEST-79-MEMPRESS:                   SUCCESS  (  2 s)
TEST-80-NOTIFYACCESS:               FAIL     (  2 s)
TEST-81-GENERATORS:                 FAIL     (  2 s)
TEST-82-SOFTREBOOT:                 FAIL     (  2 s)

TOTAL FAILURES: 56 OF 60


It appears tzdata-legacy is not installed in the autopkgtest VM despite
`tzdata-legacy | tzdata,`

Asking in #debci:

mbiebl >>
we have "Depends: tzdata-legacy | tzdata" in one of our autopkgtests.
This doesn't result in "tzdata-legacy" to be installed though (in sid)

Myon >>
why should it, when tzdata is already present
tzdata-legacy <!nocheck> | tzdata (<< 2023c-8) <!nocheck>,
(in B-D)

mbiebl >>
I thought tzdata-legacy is tried first and it only falls back to
installing tzdata if tzdata-legacy is not available

Myon >>
that's what the buildds do, but autopkgtest is different
but even there it will likely just use tzdata when that is already
installed from the base system, I think

mbiebl >>
ok, good to know
Will use tzdata-legacy <!nocheck> | tzdata (<< 2023c-8) <!nocheck> for
b-dep and tzdata-legacy | tzdata (<< 2023c-8) for debian/tests/control
then
helmut >>
@mbiebl  tzdata-legacy will be tried first unless one of the
alternatives is already satisfied at the time of resolving. your
solution is correct.
admittedly that number of packages that need a dependency on
tzdata-legacy makes me question whether the split was performed in the
right way