Bug#1051843: systemd: Restart=on-failure causes OnSuccess to trigger

[Cornelius Hoffmann]

Package: systemd
Version: 252.12-1~deb12u1
Severity: normal

This issue was already reported upstream
(https://github.com/systemd/systemd/issues/26903) and is already
resolved upstream and shipped in release 254. The upstream PR for the
fix is
https://github.com/systemd/systemd/pull/28215.

A simple testcase is creating two unit files
```
# /etc/systemd/system/myservice.service
[Unit]
OnSuccess=mysuccess.service
StartLimitBurst=2
StartLimitIntervalSec=1h


[Service]
Type=oneshot
ExecStart=/usr/bin/false
Restart=on-failure

# /etc/systemd/system/mysuccess.service
[Service]
Type=oneshot
ExecStart=/usr/bin/true
```

Starting myservice.service also causes mysuccess.service to be started.
A backport of the pull request mentioned above would be nice.


-- Package-specific info:

-- System Information:
Debian Release: 12.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-11-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages systemd depends on:
ii  libacl1            2.3.1-3
ii  libaudit1          1:3.0.9-1
ii  libblkid1          2.38.1-5+b1
ii  libc6              2.36-9+deb12u1
ii  libcap2            1:2.66-4
ii  libcryptsetup12    2:2.6.1-4~deb12u1
ii  libfdisk1          2.38.1-5+b1
ii  libgcrypt20        1.10.1-3
ii  libkmod2           30+20221128-1
ii  liblz4-1           1.9.4-1
ii  liblzma5           5.4.1-0.2
ii  libmount1          2.38.1-5+b1
ii  libp11-kit0        0.24.1-2
ii  libseccomp2        2.5.4-1+b3
ii  libselinux1        3.4-1+b6
ii  libssl3            3.0.9-1
ii  libsystemd-shared  252.12-1~deb12u1
ii  libsystemd0        252.12-1~deb12u1
ii  libzstd1           1.5.4+dfsg2-5
ii  mount              2.38.1-5+b1

Versions of packages systemd recommends:
ii  dbus [default-dbus-system-bus]   1.14.8-2~deb12u1
ii  dbus-broker [dbus-system-bus]    33-1
ii  systemd-timesyncd [time-daemon]  252.12-1~deb12u1

Versions of packages systemd suggests:
ii  libfido2-1            1.12.0-2+b1
ii  libqrencode4          4.1.1-1
ii  libtss2-esys-3.0.2-0  3.2.1-3
ii  libtss2-mu0           3.2.1-3
ii  libtss2-rc0           3.2.1-3
ii  policykit-1           122-3
ii  polkitd               122-3
ii  systemd-boot          252.12-1~deb12u1
ii  systemd-container     252.12-1~deb12u1
pn  systemd-homed         <none>
ii  systemd-resolved      252.12-1~deb12u1
pn  systemd-userdbd       <none>

Versions of packages systemd is related to:
ii  dbus-user-session  1.14.8-2~deb12u1
ii  dracut             059-4
pn  initramfs-tools    <none>
ii  libnss-systemd     252.12-1~deb12u1
ii  libpam-systemd     252.12-1~deb12u1
ii  udev               252.12-1~deb12u1

-- no debconf information