[Pkg-sysvinit-devel] Re: r329 - sysvinit/trunk/debian/initscripts/etc/init.d

[Petter Reinholdtsen]

[Thomas Hood]
> Author: jdthood-guest
> Date: 2005-11-29 09:54:56 +0000 (Tue, 29 Nov 2005)
> New Revision: 329
>
> Modified:
>    sysvinit/trunk/debian/initscripts/etc/init.d/bootmisc.sh
> Log:
> chgrp on dmesg log file; use which to test for runnability
>
> Modified: sysvinit/trunk/debian/initscripts/etc/init.d/bootmisc.sh
> ===================================================================
> --- sysvinit/trunk/debian/initscripts/etc/init.d/bootmisc.sh	2005-11-28 22:13:54 UTC (rev 328)
> +++ sysvinit/trunk/debian/initscripts/etc/init.d/bootmisc.sh	2005-11-29 09:54:56 UTC (rev 329)
> @@ -50,10 +50,11 @@
>  	fi
>  
>  	# Save kernel messages in /var/log/dmesg
> -	if [ -x /bin/dmesg ] || [ -x /sbin/dmesg ]
> +	if which dmesg >/dev/null 2>&1

Is this safe?  The which command is part of bash, but is it part of
all the other /bin/sh candidates?  I am quite sure /usr/bin/which is
not safe to call at this point in the boot, and that is the
replacement.