[Pkg-sysvinit-devel] Re: [Pkg-sysvinit-commits] r448 - sysvinit/trunk/debian/initscripts/etc/init.d

[Thomas Hood]

Henrique de Moraes Holschuh wrote:
> On Sat, 24 Dec 2005, Thomas Hood wrote:
>> -		MOUNT_OUT="$(do_mount)"
>> +		MOUNT_OUT="$(LANG=C do_mount)"
> 
> If you want to FORCE a charset, you have to use LC_ALL, not LANG.  LANG is
> just a default that is easily overriden. LC_ALL is the master override.


OK, thanks for telling me this.  I am no expert in locale matters.
I have just committed the appended change.  Note, though, that the handling
of mount return status and messages still needs work.         // Thomas

$ svn diff -r448:449
Password:
Password:
Password:
Password:
Password:
Index: umountfs
===================================================================
--- umountfs    (revision 448)
+++ umountfs    (revision 449)
@@ -33,7 +33,7 @@
        # Umount all filesystems except root and the virtual ones
        log_action_begin_msg "Unmounting local filesystems"
        # List all mounts, deepest mount point first
-       LANG=C sort -r -k 2 /proc/mounts |
+       LC_ALL=C sort -r -k 2 /proc/mounts |
        (
                DIRS=""
                while read DEV DIR TYPE REST ; do
Index: mountnfs.sh
===================================================================
--- mountnfs.sh (revision 448)
+++ mountnfs.sh (revision 449)
@@ -110,7 +110,7 @@
                                fi
                        else
                                log_action_begin_msg "Mounting remote filesystems"
-                               MOUNT_OUT="$(LANG=C do_mount)"
+                               MOUNT_OUT="$(LC_ALL=C do_mount)"
                                ES=$?
                                echo "$MOUNT_OUT" | sed -e '/already mounted/d' -e '/nothing was mounted/d'
                                if [ 0 = "$ES" ] || [ 96 = "$ES" ] || [ 64 = "$ES" ]
Index: mountall.sh
===================================================================
--- mountall.sh (revision 448)
+++ mountall.sh (revision 449)
@@ -44,7 +44,7 @@
                fi
        else
                log_action_begin_msg "Mounting local filesystems"
-               MOUNT_OUT="$(LANG=C do_mount)"
+               MOUNT_OUT="$(LC_ALL=C do_mount)"
                ES=$?
                echo "$MOUNT_OUT" | sed -e '/already mounted/d' -e '/nothing was mounted/d'
                if [ 0 = "$ES" ] || [ 96 = "$ES" ] || [ 64 = "$ES" ]


-- 
Thomas