[Pkg-sysvinit-devel] Bug#326678: marked as done (sulogin: Handle
locket root account gracefully)
Debian Bug Tracking System
owner at bugs.debian.org
Sat Nov 19 15:03:17 UTC 2005
Your message dated Sat, 19 Nov 2005 06:32:10 -0800
with message-id <E1EdTlC-00031o-IU at spohr.debian.org>
and subject line Bug#326678: fixed in sysvinit 2.86.ds1-6
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 4 Sep 2005 22:43:33 +0000
>From pre at saruman.uio.no Sun Sep 04 15:43:32 2005
Return-path: <pre at saruman.uio.no>
Received: from pat.uio.no [129.240.130.16] (7411)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EC3D2-0000cz-00; Sun, 04 Sep 2005 15:43:32 -0700
Received: from mail-mx2.uio.no ([129.240.10.30])
by pat.uio.no with esmtp (Exim 4.43)
id 1EC3Cz-0003P7-0o
for submit at bugs.debian.org; Mon, 05 Sep 2005 00:43:29 +0200
Received: from saruman.uio.no ([129.240.201.202])
by mail-mx2.uio.no with esmtp (Exim 4.43)
id 1EC3Cu-0001FZ-Ua; Mon, 05 Sep 2005 00:43:24 +0200
Received: from pre by saruman.uio.no with local (Exim 4.44)
id 1EC3Cu-0002Sg-Ho; Mon, 05 Sep 2005 00:43:24 +0200
To: submit at bugs.debian.org
Subject: sulogin: Handle locket root account gracefully
From: Petter Reinholdtsen <pere at hungry.com>
Message-Id: <E1EC3Cu-0002Sg-Ho at saruman.uio.no>
Sender: Petter Reinholdtsen <petter.reinholdtsen at usit.uio.no>
Date: Mon, 05 Sep 2005 00:43:24 +0200
X-UiO-Spam-info: not spam, SpamAssassin (score=-5.602, required 12,
autolearn=disabled, ALL_TRUSTED -2.82, AWL 2.22,
UIO_MAIL_IS_INTERNAL -5.00)
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Package: sysvinit
Version: 2.86.ds1-1
Severity: wishlist
Tags: patch
While reviewing the patches from ubuntu to the sysvinit package, I
came across a patch to handle locked root accounts. This is used when
booting and the file system check fail, to allow the user to fix the
problem. In ubuntu, the root account is locked, and normally all root
access is done using sudo. This change might be interesting for
Debian too, to make it possible to set up Debian with sudo only.
This is the relevant changelog entry:
sysvinit (2.85-22ubuntu3) warty; urgency=low
* src/sulogin.c: Enable root login with a locked password
-- Thom May <thom at planetarytramp.net> Mon, 23 Aug 2004 20:32:54 +0100
And here is the patch.
diff -pruN sysvinit_2.86.ds1-1.1/src/sulogin.c sysvinit_2.86.ds1-1.1ubuntu5/src/sulogin.c
--- sysvinit_2.86.ds1-1.1/src/sulogin.c2004-07-30 12:40:28.000000000 +0100
+++ sysvinit_2.86.ds1-1.1ubuntu5/src/sulogin.c2005-08-31 13:37:24.000000000 +0100
@@ -234,7 +234,11 @@ struct passwd *getrootpwent(int try_manu
fprintf(stderr, "%s: no entry for root\n", F_SHADOW);
strcpy(pwd.pw_passwd, "");
}
-if (!valid(pwd.pw_passwd)) {
+
+ /* disabled passwords are valid too */
+if (!(strcmp(pwd.pw_passwd, "*") == 0) ||
+ !(strcmp(pwd.pw_passwd, "!") == 0) ||
+ !valid(pwd.pw_passwd)) {
fprintf(stderr, "%s: root password garbled\n", F_SHADOW);
strcpy(pwd.pw_passwd, ""); }
return &pwd;
@@ -437,6 +441,13 @@ int main(int argc, char **argv)
sleep(2);
}
+ /*
+ * If the root password is locked, fire up a shell
+ */
+ if ((strcmp(pwd->pw_passwd, "*") == 0) ||
+ (strcmp(pwd->pw_passwd, "!") == 0))
+ sushell(pwd);
+
/*
*Ask for the password.
*/
---------------------------------------
Received: (at 326678-close) by bugs.debian.org; 19 Nov 2005 14:41:21 +0000
>From katie at ftp-master.debian.org Sat Nov 19 06:41:21 2005
Return-path: <katie at ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1EdTlC-00031o-IU; Sat, 19 Nov 2005 06:32:10 -0800
From: Petter Reinholdtsen <pere at debian.org>
To: 326678-close at bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#326678: fixed in sysvinit 2.86.ds1-6
Message-Id: <E1EdTlC-00031o-IU at spohr.debian.org>
Sender: Archive Administrator <katie at ftp-master.debian.org>
Date: Sat, 19 Nov 2005 06:32:10 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: sysvinit
Source-Version: 2.86.ds1-6
We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive:
initscripts_2.86.ds1-6_i386.deb
to pool/main/s/sysvinit/initscripts_2.86.ds1-6_i386.deb
sysv-rc_2.86.ds1-6_all.deb
to pool/main/s/sysvinit/sysv-rc_2.86.ds1-6_all.deb
sysvinit_2.86.ds1-6.diff.gz
to pool/main/s/sysvinit/sysvinit_2.86.ds1-6.diff.gz
sysvinit_2.86.ds1-6.dsc
to pool/main/s/sysvinit/sysvinit_2.86.ds1-6.dsc
sysvinit_2.86.ds1-6_i386.deb
to pool/main/s/sysvinit/sysvinit_2.86.ds1-6_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 326678 at bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere at debian.org> (supplier of updated sysvinit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster at debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 19 Nov 2005 15:07:33 +0100
Source: sysvinit
Binary: sysv-rc sysvinit initscripts
Architecture: source i386 all
Version: 2.86.ds1-6
Distribution: unstable
Urgency: low
Maintainer: sysvinit maintainers <pkg-sysvinit-devel at lists.alioth.debian.org>
Changed-By: Petter Reinholdtsen <pere at debian.org>
Description:
initscripts - Standard scripts needed for booting and shutting down
sysv-rc - Standard boot mechanism using symlinks in /etc/rc?.d
sysvinit - System-V like init
Closes: 326678 338966 338966 338967 339351
Changes:
sysvinit (2.86.ds1-6) unstable; urgency=low
.
[ Petter Reinholdtsen ]
* Updated versioned dependency of sysvinit from sysv-rc version
2.85-2 to version 2.86.ds1-1.2, to make sure init.d/rcS calls all
init.d scripts with 'start' argument. Let initscripts conflict
with sysv-rc (<< 2.86.ds1-1.2) as well, to document that it need a
newer sysv-rc to work properly. (Closes: #338966)
* Added 91_sulogin_lockedpw.dpatch to make sure file systems can be
fixed on machines with locked root accounts too, by presenting a
shell in these cases. Patch from Ubuntu and Thom May.
(Closes: #326678)
* Make sure checkroot.sh calls mountvirtfs with argument 'start', to
avoid usage message and making sure it is executed as it
should. (Closes: #338966, #339351)
* Print message when hostname is set. Use default 'localhost' if no
hostname is set in /etc/hostname, and no current hostname is set.
* In mountall.sh, add '-e' to swapon call, to ignore missing devices
when enabling swap. Because of this, show error messages from
swapon.
* Add link to alioth project page in the Debian README.
* Created new file /lib/init/functions.sh for functions common to
scripts in initscripts. Moved dir_writable() into it.
* Add new function selinux_enabled(). Use it before running
/sbin/restorecon.
.
[ Thomas Hood ]
* Improve update-rc.d man page text.
* Use log_action_* functions from recent (>= 3.0-6) lsb-base, to
improve output formatting. (Closes: #338967)
* Clean up initscripts messages a bit, making them easier to
understand for non-technical users.
Files:
273c41c3d803b4af656a78b088af0646 810 admin required sysvinit_2.86.ds1-6.dsc
5ed7c9f9aff06d43e2ce78679cdf0b5c 95038 admin required sysvinit_2.86.ds1-6.diff.gz
63314b6aa209f7ea18eb127e65c91bd3 102764 admin required sysvinit_2.86.ds1-6_i386.deb
bb4d5166bdb8556d0ff87fd423587493 38228 admin required initscripts_2.86.ds1-6_i386.deb
474cee5a103b16c1f2c057de7b345ae9 40218 admin required sysv-rc_2.86.ds1-6_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDfzO620zMSyow1ykRAnC0AKC9JyYR9NT+7kFHp7qRxu3R8A/M7QCfei9Q
dOyoK/HX2GgA7BXLwrhiHuw=
=mFM6
-----END PGP SIGNATURE-----
More information about the Pkg-sysvinit-devel
mailing list