[Pkg-sysvinit-devel] Bug#339850: Comments on the patch

[Thomas Hood]

Comments on the patch:

We can't rm the flag file in halt/reboot because this script runs after the root
filesystem has been remounted read-only.

Assume that the flag file is deleted earlier. Does the code make sense?  It currently
thinks: If the flag file is present on the root filesystem then filesystems other
than the root filesystem should be checked.  But the flag file may be present even
though non-root filesystems have been cleanly unmounted; and the flag file may be
absent even though the root filesystem was not cleanly unmounted.  It would be more
reliable to base the decision on filesystem metadata.  Can we use some program,
perhaps fsck itself, to find out whether each filesystem was unmounted cleanly last
time?  And isn't this what already happens?

We already have /forcefsck and /fastboot.  Now the proposal is to add /.autofsck.
Perhaps we should be more consistent in how we name these files.
--
Thomas